From: Don Zickus <dzickus@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Cyrill Gorcunov <gorcunov@openvz.org>,
Lin Ming <ming.m.lin@intel.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] perf, x86: P4 PMU - Don't forget to clear cpuc->active_mask on overflow
Date: Thu, 21 Apr 2011 09:57:42 -0400 [thread overview]
Message-ID: <20110421135742.GZ20887@redhat.com> (raw)
In-Reply-To: <20110421131748.GB1642@elte.hu>
On Thu, Apr 21, 2011 at 03:17:48PM +0200, Ingo Molnar wrote:
>
> * Don Zickus <dzickus@redhat.com> wrote:
>
> > On Wed, Apr 20, 2011 at 07:13:37PM +0400, Cyrill Gorcunov wrote:
> > > It's not enough to simply disable event on overflow the cpuc->active_mask
> > > should be cleared as well otherwise counter may stall in "active" even
> > > in real being already disabled (which potentially may lead to the situation
> > > that user may not use this counter further).
> >
> > I also noticed this patch fixed some unknown NMIs on a P4 when I stressed
> > the box
> >
> > Acked-by: Don Zickus <dzickus@redhat.com>
>
> Ok. Mind one of you resending all pending patches in this area, with all
> Acked-by's and Tested-by's in place?
Cyril is that something you can do because I think all of these patches
revolve around P4 fixes? Though I don't know what are all the patches. I
know I had one and this patch. Is there another on Cyril?
Cheers,
Don
next prev parent reply other threads:[~2011-04-21 13:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 15:13 [PATCH -tip] perf, x86: P4 PMU - Don't forget to clear cpuc->active_mask on overflow Cyrill Gorcunov
2011-04-21 6:34 ` Lin Ming
2011-04-21 12:53 ` Don Zickus
2011-04-21 13:17 ` Ingo Molnar
2011-04-21 13:57 ` Don Zickus [this message]
2011-04-21 14:00 ` Cyrill Gorcunov
2011-04-21 14:22 ` Don Zickus
2011-04-21 13:58 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110421135742.GZ20887@redhat.com \
--to=dzickus@redhat.com \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.