From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: linux-next: build failure after merge of the final tree (battery tree related) Date: Fri, 22 Apr 2011 03:27:03 +0400 Message-ID: <20110421232703.GA16294@oksana.dev.rtsoft.ru> References: <20110422080555.c7cd0e0b.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:55087 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754943Ab1DUX1J (ORCPT ); Thu, 21 Apr 2011 19:27:09 -0400 Content-Disposition: inline In-Reply-To: <20110422080555.c7cd0e0b.sfr@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, MyungJoo Ham , Martin Schwidefsky , Heiko Carstens Hi Stephen, On Fri, Apr 22, 2011 at 08:05:55AM +1000, Stephen Rothwell wrote: > Hi Anton, > > After merging the final tree, today's linux-next build (s390 allyesconfig) > failed like this: > > drivers/built-in.o: In function `max8903_remove': > drivers/power/max8903_charger.c:355: undefined reference to `free_irq' > drivers/power/max8903_charger.c:357: undefined reference to `free_irq' > drivers/power/max8903_charger.c:359: undefined reference to `free_irq' I added the following patch to the battery-2.6.git, so this should be fixed now. Thanks! commit 6f9efe76cb213e9b0dd89e465efaf9725f4bf492 Author: Anton Vorontsov Date: Fri Apr 22 03:08:22 2011 +0400 max8903_charger: Add GENERIC_HARDIRQS as a dependency (fixes S390 build) S390 is special as it doesn't have IRQ lines, so these errors pop up: drivers/built-in.o: In function 'max8903_remove': drivers/power/max8903_charger.c:355: undefined reference to 'free_irq' drivers/power/max8903_charger.c:357: undefined reference to 'free_irq' drivers/power/max8903_charger.c:359: undefined reference to 'free_irq' This commit fixes the issue by making the driver depend on GENERIC_HARDIRQS feature. Reported-by: Stephen Rothwell Signed-off-by: Anton Vorontsov diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig index 1f50ebc..cc019c9 100644 --- a/drivers/power/Kconfig +++ b/drivers/power/Kconfig @@ -205,6 +205,7 @@ config CHARGER_ISP1704 config CHARGER_MAX8903 tristate "MAX8903 Battery DC-DC Charger for USB and Adapter Power" + depends on GENERIC_HARDIRQS help Say Y to enable support for the MAX8903 DC-DC charger and sysfs. The driver supports controlling charger-enable and current-limit