All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tommi Virtanen <tommi.virtanen@dreamhost.com>
To: Sage Weil <sage@newdream.net>
Cc: Yehuda Sadeh Weinraub <yehudasa@gmail.com>,
	Gregory Farnum <gregory.farnum@dreamhost.com>,
	ceph-devel@vger.kernel.org
Subject: Re: long object names
Date: Fri, 22 Apr 2011 09:34:59 -0700	[thread overview]
Message-ID: <20110422163459.GA16595@dreamer> (raw)
In-Reply-To: <Pine.LNX.4.64.1104220818210.15351@cobra.newdream.net>

On Fri, Apr 22, 2011 at 08:44:49AM -0700, Sage Weil wrote:
> - We can easily wrap the non-fast past with a mutex to avoid the races 
> (because, again, collisions are vanishingly rare except in our test 
> cases).

How do you guard against crashes, e.g. the create+set_xattr crashing
before set_xattr?

How do you guard against gaps in the sequence number thing? (Perhaps
make that part a random string, and change consumers to listdir
instead of probing 1,2,3...)

How do you convince yourself you've covered all the races?

> - For simplicity, I still think the simplest thing will be to push all the 
> escaping/mangling into one layer.  Once place to audit and unit test.

I think the big functional benefit with that is that you can have the
suffix not be obscured by the hash; FOO_a43fec_n_head not FOO_a43fec_n

-- 
:(){ :|:&};:

  reply	other threads:[~2011-04-22 16:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-21  4:42 long object names Sage Weil
2011-04-21 18:56 ` Tommi Virtanen
2011-04-21 19:27   ` Colin McCabe
2011-04-21 19:32     ` Tommi Virtanen
2011-04-21 20:03       ` Gregory Farnum
2011-04-21 21:09         ` Colin McCabe
2011-04-21 21:23           ` Yehuda Sadeh Weinraub
2011-04-21 21:44             ` Colin McCabe
2011-04-21 21:54               ` Yehuda Sadeh Weinraub
2011-04-21 22:01                 ` Colin McCabe
2011-04-21 22:58                   ` Zenon Panoussis
2011-04-21 23:04                     ` Yehuda Sadeh Weinraub
2011-04-21 22:00         ` Tommi Virtanen
2011-04-21 22:23           ` Gregory Farnum
2011-04-21 22:25           ` Yehuda Sadeh Weinraub
2011-04-21 23:07             ` Tommi Virtanen
2011-04-22 15:44               ` Sage Weil
2011-04-22 16:34                 ` Tommi Virtanen [this message]
2011-04-22 17:36                 ` Colin McCabe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110422163459.GA16595@dreamer \
    --to=tommi.virtanen@dreamhost.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=gregory.farnum@dreamhost.com \
    --cc=sage@newdream.net \
    --cc=yehudasa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.