From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 02/23] at91: Make Ethernet device common
Date: Tue, 26 Apr 2011 06:35:52 +0200 [thread overview]
Message-ID: <20110426043552.GH12904@game.jcrosoft.org> (raw)
In-Reply-To: <4DB5D686.5050208@bluewatersys.com>
On 08:16 Tue 26 Apr , Ryan Mallon wrote:
> On 04/22/2011 11:02 AM, H Hartley Sweeten wrote:
> > On Wednesday, April 20, 2011 10:42 PM, Ryan Mallon wrote:
> >>
> >> Replace the individual Ethernet device code for each at91 variant with
> >> a single implementation in devices.
> >>
> >> Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
> >> ---
> >>
> >> arch/arm/mach-at91/at572d940hf.c | 4 +
> >> arch/arm/mach-at91/at572d940hf_devices.c | 83 +++++++----------------
> >> arch/arm/mach-at91/at91cap9.c | 4 +
> >> arch/arm/mach-at91/at91cap9_devices.c | 103 ++++++++++------------------
> >> arch/arm/mach-at91/at91rm9200.c | 4 +
> >> arch/arm/mach-at91/at91rm9200_devices.c | 103 ++++++++++------------------
> >> arch/arm/mach-at91/at91sam9260.c | 4 +
> >> arch/arm/mach-at91/at91sam9260_devices.c | 104 +++++++++++------------------
> >> arch/arm/mach-at91/at91sam9263.c | 4 +
> >> arch/arm/mach-at91/at91sam9263_devices.c | 102 ++++++++++------------------
> >> arch/arm/mach-at91/at91sam9g45.c | 4 +
> >> arch/arm/mach-at91/at91sam9g45_devices.c | 108 +++++++++++-------------------
> >> arch/arm/mach-at91/devices.c | 61 +++++++++++++++++
> >> arch/arm/mach-at91/devices.h | 10 +++
> >> 14 files changed, 309 insertions(+), 389 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-at91/at572d940hf.c b/arch/arm/mach-at91/at572d940hf.c
> >> index a6b9c68..48c1ec2 100644
> >> --- a/arch/arm/mach-at91/at572d940hf.c
> >> +++ b/arch/arm/mach-at91/at572d940hf.c
> >> @@ -34,6 +34,8 @@
> >> #include "generic.h"
> >> #include "clock.h"
> >>
> >> +extern void at572d940hf_init_devices(void);
> >
> > You might consider moving this, and all the other similar externs, to the generic.h
> > header. That's where all the other platform init functions are defined.
>
> I put the externs in the .c files since that is the only place they are
> actually called from. What is the general consensus on this?
no I do not want to 1000 of export function again
with the new soc we do not need it anymore
Best Regards,
J.
next prev parent reply other threads:[~2011-04-26 4:35 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 5:41 [PATCH v2 00/23] at91: Replace duplicate device initialisation code with Ryan Mallon
2011-04-21 5:41 ` [PATCH v2 01/23] at91: Add common devices framework Ryan Mallon
2011-04-21 5:41 ` [PATCH v2 02/23] at91: Make Ethernet device common Ryan Mallon
2011-04-21 23:02 ` H Hartley Sweeten
2011-04-25 20:16 ` Ryan Mallon
2011-04-26 4:35 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-04-26 5:26 ` Ryan Mallon
2011-04-21 23:19 ` H Hartley Sweeten
2011-04-25 20:15 ` Ryan Mallon
2011-04-28 9:15 ` Russell King - ARM Linux
2011-04-28 17:57 ` H Hartley Sweeten
2011-04-28 18:31 ` Russell King - ARM Linux
2011-04-28 20:46 ` H Hartley Sweeten
2011-04-29 19:32 ` Uwe Kleine-König
2011-04-28 21:34 ` Ryan Mallon
2011-04-28 21:54 ` Russell King - ARM Linux
2011-04-21 5:41 ` [PATCH v2 03/23] at91: Make USB OHCI/EHCI devices common Ryan Mallon
2011-04-21 5:41 ` [PATCH v2 04/23] at91: Make UDC device common Ryan Mallon
2011-04-21 5:41 ` [PATCH v2 05/23] at91: Make MMC " Ryan Mallon
2011-04-21 5:41 ` [PATCH v2 06/23] at91: Make NAND " Ryan Mallon
2011-04-21 5:41 ` [PATCH v2 07/23] at91: Make TWI " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 08/23] at91: Make SPI " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 09/23] at91: Make TCB " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 10/23] at91: Make RTT " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 11/23] at91: Make watchdog " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 13/23] at91: Make PWM " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 14/23] at91: Make SSC " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 15/23] at91: Make AC97 " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 16/23] at91: Make LCD controller " Ryan Mallon
2011-04-21 7:02 ` Uwe Kleine-König
2011-04-21 7:13 ` Ryan Mallon
2011-04-21 12:43 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-21 5:42 ` [PATCH v2 17/23] at91: Make touchscreen " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 18/23] at91: Make HDMAC " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 19/23] at91: Make RTC " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 20/23] at91: Make high speed USB gadget " Ryan Mallon
2011-04-21 21:21 ` H Hartley Sweeten
2011-04-21 21:28 ` Ryan Mallon
2011-04-21 21:53 ` H Hartley Sweeten
2011-04-21 5:42 ` [PATCH v2 21/23] at91: Make compact flash " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 22/23] at91: Move at91sam9263 CAN device to common devices Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 23/23] at91: Remove mAgic and ISI device code Ryan Mallon
2011-04-21 17:33 ` H Hartley Sweeten
2011-04-21 20:12 ` Ryan Mallon
2011-04-26 4:39 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-26 5:30 ` Ryan Mallon
2011-04-28 9:19 ` Russell King - ARM Linux
2011-04-28 9:23 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-21 5:43 ` [PATCH v2 12/23] at91: Make UART devices common Ryan Mallon
2011-04-21 17:02 ` [PATCH v2 00/23] at91: Replace duplicate device initialisation code with H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110426043552.GH12904@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.