All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: John Stultz <john.stultz@linaro.org>
Cc: linux-kernel@vger.kernel.org, Arve Hj?nnev?g <arve@android.com>,
	Dave Hansen <dave@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm: Check if any page in a pageblock is reserved before marking it MIGRATE_RESERVE
Date: Tue, 26 Apr 2011 08:34:10 +0100	[thread overview]
Message-ID: <20110426073410.GA4658@suse.de> (raw)
In-Reply-To: <1303436043-26644-1-git-send-email-john.stultz@linaro.org>

On Thu, Apr 21, 2011 at 06:34:03PM -0700, John Stultz wrote:
> From: Arve Hjønnevåg <arve@android.com>
> 
> This fixes a problem where the first pageblock got marked MIGRATE_RESERVE even
> though it only had a few free pages. This in turn caused no contiguous memory
> to be reserved and frequent kswapd wakeups that emptied the caches to get more
> contiguous memory.
> 
> CC: Dave Hansen <dave@linux.vnet.ibm.com>
> CC: Mel Gorman <mgorman@suse.de>
> CC: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Arve Hjønnevåg <arve@android.com>
> Acked-by: Mel Gorman <mel@csn.ul.ie>
> 
> [This patch was submitted and acked a little over a year ago
> (see: http://lkml.org/lkml/2010/4/6/172 ), but never seemingly
> made it upstream. Resending for comments. -jstultz]
> 
> Signed-off-by: John Stultz <john.stultz@linaro.org>

Whoops, should have spotted it slipped through. FWIW, I'm still happy
with my Ack being stuck onto it.

Thanks.

-- 
Mel Gorman
SUSE Labs

  parent reply	other threads:[~2011-04-26  7:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-22  1:34 [PATCH] mm: Check if any page in a pageblock is reserved before marking it MIGRATE_RESERVE John Stultz
2011-04-22 16:02 ` Dave Hansen
2011-04-26  7:34 ` Mel Gorman [this message]
2011-04-26  9:49   ` KOSAKI Motohiro
2011-04-26 10:13     ` Mel Gorman
2011-04-26 17:51     ` John Stultz
  -- strict thread matches above, loose matches on Subject: below --
2010-04-05 10:14 [Question] race condition in mm/page_alloc.c regarding page->lru? Mel Gorman
2010-04-06  3:09 ` [PATCH] mm: Check if any page in a pageblock is reserved before marking it MIGRATE_RESERVE Arve Hjønnevåg
2010-04-06  3:09   ` Arve Hjønnevåg
2010-04-06  3:09   ` Arve Hjønnevåg
2010-04-06  4:15   ` Minchan Kim
2010-04-06  4:15     ` Minchan Kim
2010-04-06  4:15     ` Minchan Kim
2010-04-06 15:11   ` Mel Gorman
2010-04-06 15:11     ` Mel Gorman
2010-04-06 15:11     ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110426073410.GA4658@suse.de \
    --to=mgorman@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=arve@android.com \
    --cc=dave@linux.vnet.ibm.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.