All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: kvm@vger.kernel.org
Cc: avi@redhat.com, mtosatti@redhat.com
Subject: Re: [PATCH 1/5] KVM: mmio_fault_cr2 is not used.
Date: Tue, 26 Apr 2011 11:25:37 +0300	[thread overview]
Message-ID: <20110426082537.GH2265@redhat.com> (raw)
In-Reply-To: <1302600985-10704-1-git-send-email-gleb@redhat.com>

Ping? What about those patches? 2/5 should be dropped, but others are
not yet applied too as far as I see.

On Tue, Apr 12, 2011 at 12:36:21PM +0300, Gleb Natapov wrote:
> Remove unused variable mmio_fault_cr2.
> 
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> ---
>  arch/x86/include/asm/kvm_host.h |    1 -
>  arch/x86/kvm/x86.c              |    2 +-
>  2 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index bd57639..c1a7f54 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -358,7 +358,6 @@ struct kvm_vcpu_arch {
>  	struct fpu guest_fpu;
>  	u64 xcr0;
>  
> -	gva_t mmio_fault_cr2;
>  	struct kvm_pio_request pio;
>  	void *pio_data;
>  
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 1d5a7f4..b568779 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -4504,7 +4504,7 @@ int x86_emulate_instruction(struct kvm_vcpu *vcpu,
>  	struct decode_cache *c = &vcpu->arch.emulate_ctxt.decode;
>  
>  	kvm_clear_exception_queue(vcpu);
> -	vcpu->arch.mmio_fault_cr2 = cr2;
> +
>  	/*
>  	 * TODO: fix emulate.c to use guest_read/write_register
>  	 * instead of direct ->regs accesses, can save hundred cycles
> -- 
> 1.7.2.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
			Gleb.

  parent reply	other threads:[~2011-04-26  8:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12  9:36 [PATCH 1/5] KVM: mmio_fault_cr2 is not used Gleb Natapov
2011-04-12  9:36 ` [PATCH 2/5] KVM: emulator: sysexit should #GP in non protected mode Gleb Natapov
2011-04-12 12:17   ` Avi Kivity
2011-04-12 12:23     ` Gleb Natapov
2011-04-12 12:30       ` Avi Kivity
2011-04-12  9:36 ` [PATCH 3/5] KVM: emulator: Propagate fault in far jump emulation Gleb Natapov
2011-04-12  9:36 ` [PATCH 4/5] KVM: Fix compound mmio Gleb Natapov
2011-04-12 12:19   ` Avi Kivity
2011-04-12 12:22     ` Gleb Natapov
2011-04-12 12:27       ` Avi Kivity
2011-04-12 12:34         ` Gleb Natapov
2011-04-12 12:41           ` Avi Kivity
2011-04-12  9:36 ` [PATCH 5/5] KVM: call cache_all_regs() only once during instruction emulation Gleb Natapov
2011-04-26  8:25 ` Gleb Natapov [this message]
2011-04-26 10:15   ` [PATCH 1/5] KVM: mmio_fault_cr2 is not used Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110426082537.GH2265@redhat.com \
    --to=gleb@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.