From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/4] davinci-mcasp: correct tdm_slots limit Date: Tue, 26 Apr 2011 11:46:36 +0100 Message-ID: <20110426104635.GA13252@opensource.wolfsonmicro.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 4F3C9243B7 for ; Tue, 26 Apr 2011 12:46:38 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Ben Gardiner Cc: alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, James Nuss , Sekhar Nori , davinci-linux-open-source@linux.davincidsp.com, Liam Girdwood List-Id: alsa-devel@alsa-project.org On Thu, Apr 21, 2011 at 02:19:01PM -0400, Ben Gardiner wrote: > The current check for the number of tdm-slots specified by platform data is > always true (x >= 2 || x <= 32); therefore the else branch that warns of an > incorrect number of slots can never be taken. Applied all of these. Please always try to ensure that your commit logs are consistent with the rest of the subsystem so they don't need to be rewritten. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754273Ab1DZKqk (ORCPT ); Tue, 26 Apr 2011 06:46:40 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:60122 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753957Ab1DZKqj (ORCPT ); Tue, 26 Apr 2011 06:46:39 -0400 Date: Tue, 26 Apr 2011 11:46:36 +0100 From: Mark Brown To: Ben Gardiner Cc: Liam Girdwood , alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , Sekhar Nori , davinci-linux-open-source@linux.davincidsp.com, James Nuss , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] davinci-mcasp: correct tdm_slots limit Message-ID: <20110426104635.GA13252@opensource.wolfsonmicro.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: Cold hands, no gloves. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 21, 2011 at 02:19:01PM -0400, Ben Gardiner wrote: > The current check for the number of tdm-slots specified by platform data is > always true (x >= 2 || x <= 32); therefore the else branch that warns of an > incorrect number of slots can never be taken. Applied all of these. Please always try to ensure that your commit logs are consistent with the rest of the subsystem so they don't need to be rewritten.