From: Samuel Ortiz <sameo@linux.intel.com>
To: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
Cc: linux-kernel@vger.kernel.org,
broonie@opensource.wolfsonmicro.com, lrg@ti.com,
Graeme Gregory <gg@slimlogic.co.uk>
Subject: Re: [PATCHv4 1/4] MFD: TPS65910: Add new mfd device for TPS65910
Date: Tue, 26 Apr 2011 16:00:02 +0200 [thread overview]
Message-ID: <20110426140001.GA3175@sortiz-mobl> (raw)
In-Reply-To: <DFDB2D0D-E7B1-4E1E-A3CC-D61052D42E54@slimlogic.co.uk>
Hi Jorge,
On Thu, Apr 21, 2011 at 09:35:43AM -0500, Jorge Eduardo Candelaria wrote:
> From: Graeme Gregory <gg@slimlogic.co.uk>
>
> The TPS65910 chip is a power management IC for multimedia and handheld
> devices. It contains the following components:
The patch looks mostly good to me.
You may want to add a locked tps65910_set|clear_bits() API, since it seems
you're doing many read(reg), write(reg) sequences in the GPIO driver. That
could also be directly used by the regulator one.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2011-04-26 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 14:35 [PATCHv4 1/4] MFD: TPS65910: Add new mfd device for TPS65910 Jorge Eduardo Candelaria
2011-04-26 14:00 ` Samuel Ortiz [this message]
2011-04-26 14:02 ` Liam Girdwood
2011-04-26 14:28 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110426140001.GA3175@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=jedu@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.