From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Imran Haider <imran1008@gmail.com>
Cc: marcel@holtmann.org, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Don't sleep after deleting command timer
Date: Tue, 26 Apr 2011 12:49:50 -0300 [thread overview]
Message-ID: <20110426154950.GA2242@joana> (raw)
In-Reply-To: <1303513362-9357-1-git-send-email-imran1008@gmail.com>
Hi Imran,
* Imran Haider <imran1008@gmail.com> [2011-04-22 19:02:42 -0400]:
> This fix adds on to commit b77dcf84. It seems that scheduling a timeout
> of 250ms after deleting the command timer causes a kernel panic when
> system is resuming from Suspend-to-RAM. I tried adding another timeout
> before deleting the command timer but that didn't help so I believe that
> some code in hci_dev_do_close must execute after the command timer is
> deleted before control is returned to another thread.
>
> The only bit the command timer handler hci_cmd_timer() touches is HCI_RESET.
> It should be fine to delete the timer after testing the HCI_UP bit.
> ---
> net/bluetooth/hci_core.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
I already have for that. But thanks anyway. ;)
--
Gustavo F. Padovan
http://profusion.mobi
prev parent reply other threads:[~2011-04-26 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 23:02 [PATCH] Bluetooth: Don't sleep after deleting command timer Imran Haider
2011-04-26 15:49 ` Gustavo F. Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110426154950.GA2242@joana \
--to=padovan@profusion.mobi \
--cc=imran1008@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.