From: Arnd Bergmann <arnd@arndb.de>
To: Colin Cross <ccross@android.com>
Cc: John Stultz <john.stultz@linaro.org>,
linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
Dima Zavin <dima@android.com>
Subject: Re: [PATCH 2/6] mmc_block: Allow more than 8 partitions per card
Date: Tue, 26 Apr 2011 18:13:55 +0200 [thread overview]
Message-ID: <201104261813.55627.arnd@arndb.de> (raw)
In-Reply-To: <BANLkTinEiG5QGaZNp2hnOc8BmNhNc_SiwA@mail.gmail.com>
On Tuesday 26 April 2011, Colin Cross wrote:
> On Tue, Apr 26, 2011 at 6:22 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Saturday 23 April 2011, John Stultz wrote:
> >> From: Colin Cross <ccross@android.com>
> >>
> >> Set the GENHD_FL_EXT_DEVT flag, which will allocate minor numbers
> >> in major 259 for partitions past disk->minors.
> >>
> >> Also remove the use of disk_devt to determine devidx from md->disk.
> >> md->disk->first_minor is always initialized from devidx and can
> >> always be used to recover it.
> >>
> >> CC: Chris Ball <cjb@laptop.org>
> >> CC: Arnd Bergmann <arnd@arndb.de>
> >> CC: Dima Zavin <dima@android.com>
> >> Signed-off-by: Colin Cross <ccross@android.com>
> >> Signed-off-by: John Stultz <john.stultz@linaro.org>
> >
> > The new code looks reasonable, but wouldn't changing this be incompatible
> > with existing root file systems that contain static device nodes?
>
> I don't think so. Without this change, /dev/mmcblk0p1 will be (179,
> 1), /dev/mmcblk0p7 will be (179, 7), and /dev/mmcblk0p8 will be
> dropped. After this change, /dev/mmcblk0p1-7 will be the same, but
> /dev/mmcblk0p8 will be (259, <random number>). A root file system
> with static inodes will still have access to partitions 1-7, and will
> still not have access to dynamically-assigned partition 8.
Ah, I see.
The patch looks good to me then.
Arnd
next prev parent reply other threads:[~2011-04-26 16:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-23 1:01 [PATCH 0/6] Trivial MMC patches from Android John Stultz
2011-04-23 1:01 ` [PATCH 1/6] mmc: block: Resume multi-block reads after transient read errors John Stultz
2011-04-26 13:19 ` Arnd Bergmann
2011-04-27 8:16 ` Adrian Hunter
2011-04-27 8:42 ` Andrei Warkentin
2011-04-23 1:01 ` [PATCH 2/6] mmc_block: Allow more than 8 partitions per card John Stultz
2011-04-26 13:22 ` Arnd Bergmann
2011-04-26 16:10 ` Colin Cross
2011-04-26 16:13 ` Arnd Bergmann [this message]
2011-04-23 1:01 ` [PATCH 3/6] sdhci: Always pass clock request value zero to set_clock host op John Stultz
2011-04-23 1:01 ` [PATCH 4/6] mmc: sd: Add new CONFIG_MMC_PARANOID_SD_INIT for enabling retries during SD detection John Stultz
2011-04-26 13:35 ` Arnd Bergmann
2011-04-23 1:01 ` [PATCH 5/6] mmc: sd: When resuming, try a little harder to init the card John Stultz
2011-04-26 13:39 ` Arnd Bergmann
2011-04-23 1:01 ` [PATCH 6/6] mmc: sd: Add retries in re-detection John Stultz
2011-04-26 13:42 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104261813.55627.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=ccross@android.com \
--cc=cjb@laptop.org \
--cc=dima@android.com \
--cc=john.stultz@linaro.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.