From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 08/25] Staging: hv: vmbus_driver cannot be unloaded; cleanup accordingly Date: Tue, 26 Apr 2011 15:45:45 -0700 Message-ID: <20110426224545.GC31974@kroah.com> References: <1303834785-4981-1-git-send-email-kys@microsoft.com> <1303834842-5022-1-git-send-email-kys@microsoft.com> <1303834842-5022-8-git-send-email-kys@microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1303834842-5022-8-git-send-email-kys@microsoft.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devel-bounces@linuxdriverproject.org Errors-To: devel-bounces@linuxdriverproject.org To: "K. Y. Srinivasan" Cc: Abhishek Kane , Haiyang Zhang , gregkh@suse.de, linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, devel@linuxdriverproject.org List-Id: virtualization@lists.linuxfoundation.org On Tue, Apr 26, 2011 at 09:20:25AM -0700, K. Y. Srinivasan wrote: > The vmbus driver cannot be unloaded; the windows host does not > permit this. Cleanup accordingly. Woah, you just prevented this driver from ever being able to be unloaded. That's not a "cleanup" that's a major change in how things work. I'm sure, if you want to continue down this line, there are more things you can remove from the code, right? What is the real issue here? What happens if you unload the bus? What goes wrong? Can it be fixed? This is a pretty big commitment... thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759098Ab1DZWra (ORCPT ); Tue, 26 Apr 2011 18:47:30 -0400 Received: from kroah.org ([198.145.64.141]:36294 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759007Ab1DZWpv (ORCPT ); Tue, 26 Apr 2011 18:45:51 -0400 Date: Tue, 26 Apr 2011 15:45:45 -0700 From: Greg KH To: "K. Y. Srinivasan" Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, virtualization@lists.osdl.org, Haiyang Zhang , Abhishek Kane Subject: Re: [PATCH 08/25] Staging: hv: vmbus_driver cannot be unloaded; cleanup accordingly Message-ID: <20110426224545.GC31974@kroah.com> References: <1303834785-4981-1-git-send-email-kys@microsoft.com> <1303834842-5022-1-git-send-email-kys@microsoft.com> <1303834842-5022-8-git-send-email-kys@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1303834842-5022-8-git-send-email-kys@microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2011 at 09:20:25AM -0700, K. Y. Srinivasan wrote: > The vmbus driver cannot be unloaded; the windows host does not > permit this. Cleanup accordingly. Woah, you just prevented this driver from ever being able to be unloaded. That's not a "cleanup" that's a major change in how things work. I'm sure, if you want to continue down this line, there are more things you can remove from the code, right? What is the real issue here? What happens if you unload the bus? What goes wrong? Can it be fixed? This is a pretty big commitment... thanks, greg k-h