All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amos Kong <akong@redhat.com>
To: Cleber Rosa <crosa@redhat.com>
Cc: Lucas Meneghel Rodrigues <lmr@redhat.com>,
	autotest@test.kernel.org, kvm@vger.kernel.org,
	kvm-autotest@redhat.com
Subject: Re: [KVM-AUTOTEST] [AUTOTEST][PATCH] Add ability to call autotest client tests from kvm tests like a subtest.
Date: Wed, 27 Apr 2011 09:10:21 +0800	[thread overview]
Message-ID: <20110427011021.GA2534@t400> (raw)
In-Reply-To: <4DB6FF45.90407@redhat.com>

On Tue, Apr 26, 2011 at 01:22:13PM -0400, Cleber Rosa wrote:
> On 04/26/2011 11:52 AM, Lucas Meneghel Rodrigues wrote:
> >On Tue, 2011-04-26 at 23:08 +0800, Amos Kong wrote:
> >>On Tue, Apr 26, 2011 at 12:22:31PM +0200, Jiří Župka wrote:
> >>>+    else:
> >>>+        logging.error("Host cannot communicate with client by"
> >>>+                      " normal network connection.")
> >>>\ No newline at end of file
> >>>diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample
> >>>index 5d274f8..f9efb4b 100644
> >>>--- a/client/tests/kvm/tests_base.cfg.sample
> >>>+++ b/client/tests/kvm/tests_base.cfg.sample
> >>>@@ -255,11 +255,19 @@ variants:
> >>>                  test_control_file = rtc.control
> >>>              - iozone:
> >>>                  test_control_file = iozone.control
> >>>-            - flail:
> >>>+			- flail:
> >>A typo? please don't use \t for indentation.
> >^ No, flail is the actual name of this test, a syscall fuzzer, not a
> >typo.
> >
> I guess the typo Amos mentioned (and I also pointed out) is not the
> variant name but the new indentation. Right Amos?

Yes.

      reply	other threads:[~2011-04-27  1:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26 10:22 [AUTOTEST][PATCH] Add ability to call autotest client tests from kvm tests like a subtest Jiří Župka
2011-04-26 15:08 ` Amos Kong
2011-04-26 15:52   ` Lucas Meneghel Rodrigues
2011-04-26 17:22     ` [KVM-AUTOTEST] " Cleber Rosa
2011-04-27  1:10       ` Amos Kong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110427011021.GA2534@t400 \
    --to=akong@redhat.com \
    --cc=autotest@test.kernel.org \
    --cc=crosa@redhat.com \
    --cc=kvm-autotest@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lmr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.