Re: [PATCH] [SCSI] scsi_dh_alua: Attach to UNAVAILABLE/OFFLINE AAS devices

[Nikanth Karthikesan <nikanth@gmail.com>]

On Tuesday, April 26, 2011 06:27:05 PM Martin George wrote:
> The SCSI ALUA handler currently fails to attach to devices
> reporting an UNAVAILABLE/OFFLINE AAS. But given that an
> UNAVAILABLE/OFFLINE AAS can transition to other states
> like ACTIVE/OPTIMIZED, ACTIVE/NON-OPTIMIZED, etc. as per
> SPC4, this ALUA handler behavior should be rectified so
> as to attach to devices which also report an
> UNAVAILABLE/OFFLINE AAS.
> 
> The below patch enables the same.
> 
> Signed-off-by: Martin George <marting@netapp.com>

Reviewed-by: Nikanth Karthikesan <nikanth@kernel.org>

Thanks
Nikanth

> ---
>  drivers/scsi/device_handler/scsi_dh_alua.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c
> b/drivers/scsi/device_handler/scsi_dh_alua.c index 42fe529..6fec9fe 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -782,7 +782,7 @@ static int alua_bus_attach(struct scsi_device *sdev)
>  	h->sdev = sdev;
> 
>  	err = alua_initialize(sdev, h);
> -	if (err != SCSI_DH_OK)
> +	if ((err != SCSI_DH_OK) && (err != SCSI_DH_DEV_OFFLINED))
>  		goto failed;
> 
>  	if (!try_module_get(THIS_MODULE))