From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Chris Ball <cjb@laptop.org>
Cc: linux-mmc@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Subject: [PATCH 0/2] Race fixes in sdhci
Date: Wed, 27 Apr 2011 14:23:30 +0100 [thread overview]
Message-ID: <20110427132329.GA21499@opensource.wolfsonmicro.com> (raw)
I've had this pair of patches sitting in my tree for a while now (I
believe they were previously posted) providing stability improvements in
sdhci on my systems. Having looked through the code I believe but have
not confirmed that the issue is that the timeout is racing with an
actual completion of a pending task - both paths will trigger the
tasklet, and if you trigger a tasklet while it is running this causes it
to be rescheduled. The result will be that the tasklet gets run a
second time with no work pending for it.
I'm not convinced that these are the best fixes (it feels like we should
instead be closing the races down) but I don't really have time to come
up with something better myself right now so I'm pushing them out as-is
for comment.
Ben Dooks (1):
MMC: SDHCI: Check mrq->cmd in sdhci_tasklet_finish
Dimitris Papastamos (1):
MMC: SDHCI: Check mrq != NULL in sdhci_tasklet_finish
drivers/mmc/host/sdhci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
next reply other threads:[~2011-04-27 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 13:23 Mark Brown [this message]
2011-04-27 19:33 ` [PATCH 0/2] Race fixes in sdhci Andrei Warkentin
2011-04-27 20:41 ` Chris Ball
2011-04-27 21:04 ` Mark Brown
2011-04-27 21:44 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110427132329.GA21499@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ben-linux@fluff.org \
--cc=cjb@laptop.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.