From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <syrjala@sci.fi>
Subject: Re: [RFC] drm: add overlays as first class KMS objects
Date: Wed, 27 Apr 2011 17:56:54 +0300
Message-ID: <20110427145654.GB3093@sci.fi>
References: <20110425151220.2f5dc17a@jbarnes-desktop>
	<BANLkTinZeCsARyqti+Q2TeSamV-tbLpxJg@mail.gmail.com>
	<BANLkTikzFmj1Eex7CPqoqCbbtvpBhjWeFw@mail.gmail.com>
	<BANLkTinALPwg9RFa1q1h6DEB3JHt2rzG_g@mail.gmail.com>
	<b9dded$itdhjf@orsmga002.jf.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from filtteri5.pp.htv.fi (filtteri5.pp.htv.fi [213.243.153.188])
	by gabe.freedesktop.org (Postfix) with ESMTP id B9B679E78A
	for <dri-devel@lists.freedesktop.org>;
	Wed, 27 Apr 2011 07:56:59 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <b9dded$itdhjf@orsmga002.jf.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Wed, Apr 27, 2011 at 03:34:42PM +0100, Chris Wilson wrote:
> On Wed, 27 Apr 2011 16:27:55 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Wed, Apr 27, 2011 at 3:32 PM, Jerome Glisse <j.glisse@gmail.com> wro=
te:
> > > On Wed, Apr 27, 2011 at 8:19 AM, Daniel Vetter <daniel@ffwll.ch> wrot=
e:
> > >> float scale_x, scale_y;
> > >
> > > No float in kernel. Would have to use fixed point.
> > =

> > Bleh, of course ;-) 32bit with a 16 bit shift should be good enough
> > for all scaling needs
> =

> Or just specify the source size. You already know the output size...

The source size needs to be specified with sub-pixel precision.
Otherwise you can't do accurate clipping.

Another thing to consider is whether you expect user space to do the
clipping against the CRTC dimensions, or if the kernel will do it.

Personally I like the OpenWF Display approach with it's attributes,
and atomic commits. That kind of thing is a lot easier to extend than
a fixed structure which is supposed to have all the bells and whistles
from day 1.

Also some overlay related properties are in fact more CRTC properties,
eg. on OMAP3 colorkeying and alpha blending are configured for the whole
output path, not for individual overlays. Perhaps connector properties
can be abused for those, even though they have nothing to do with
connectors as such. But some way to atomically commit the whole state
should be available.

-- =

Ville Syrj=E4l=E4
syrjala@sci.fi
http://www.sci.fi/~syrjala/