From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Matt Fleming <matt@console-pimps.org>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Huang Ying <ying.huang@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86, efi: Only print warning when desc_size is smaller than defined one.
Date: Thu, 28 Apr 2011 14:05:45 +0100 [thread overview]
Message-ID: <20110428130545.GA14075@srcf.ucam.org> (raw)
In-Reply-To: <4DB850D1.30203@kernel.org>
On Wed, Apr 27, 2011 at 10:22:25AM -0700, Yinghai Lu wrote:
> 1. bootloader aka grub.efi will convert efi memmap to e820 memmap and pass it in boot params.
> and current grub.efi does not compare desc_size and struct size.
So we'll already have crashed and burned before we got here, and so this
check will never fire. I sent a patch to just remove the message on the
28th of March.
There's no way someody could ship a system with a desc_size that's
smaller than sizeof(memdesc). It wouldn't boot anything.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2011-04-28 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 22:42 [PATCH] x86, efi: Only print warning when desc_size is smaller than defined one Yinghai Lu
2011-04-27 11:39 ` Matt Fleming
2011-04-27 17:22 ` Yinghai Lu
2011-04-28 13:05 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110428130545.GA14075@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.