All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@redhat.com>
To: Anders Kaseorg <andersk@ksplice.com>
Cc: Steven Rostedt <srostedt@redhat.com>,
	Masami Hiramatsu <mhiramat@redhat.com>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jump label: Fix jump_label_text_reserved
Date: Thu, 28 Apr 2011 14:42:34 -0400	[thread overview]
Message-ID: <20110428184234.GB2559@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1104281346060.14343@dr-wily.mit.edu>

On Thu, Apr 28, 2011 at 01:53:43PM -0400, Anders Kaseorg wrote:
> This typo prevented jump_label_text_reserved from checking for any
> conflicts in the core kernel.
> 
> Signed-off-by: Anders Kaseorg <andersk@ksplice.com>
> ---
>  kernel/jump_label.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/jump_label.c b/kernel/jump_label.c
> index 3b79bd9..4aedde1 100644
> --- a/kernel/jump_label.c
> +++ b/kernel/jump_label.c
> @@ -250,7 +250,7 @@ int jump_label_text_reserved(void *start, void *end)
>  {
>  	struct jump_entry *iter;
>  	struct jump_entry *iter_start = __start___jump_table;
> -	struct jump_entry *iter_stop = __start___jump_table;
> +	struct jump_entry *iter_stop = __stop___jump_table;
>  	int conflict = 0;
>  
>  	iter = iter_start;
> -- 
> 1.7.5
> 

This is fixed in the jump label re-write patch, which is queued for
2.6.40 in the -tip tree. See: http://marc.info/?l=linux-kernel&m=130391786701337&w=2

I believe only kprobes is relying on this check. Did you hit this in
practive using kprobes?

Thanks,

-Jason

  reply	other threads:[~2011-04-28 18:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-28 17:53 [PATCH] jump label: Fix jump_label_text_reserved Anders Kaseorg
2011-04-28 18:42 ` Jason Baron [this message]
2011-04-28 19:10   ` Anders Kaseorg
2011-04-28 19:22     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110428184234.GB2559@redhat.com \
    --to=jbaron@redhat.com \
    --cc=andersk@ksplice.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    --cc=srostedt@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.