All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
Cc: laurent.pinchart@ideasonboard.com, mchebab@infradead.org,
	linux-omap@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2] OMAP3: RX-51: define vdds_csib regulator supply
Date: Fri, 29 Apr 2011 02:13:37 -0700	[thread overview]
Message-ID: <20110429091337.GV3755@atomide.com> (raw)
In-Reply-To: <1304061120-6383-3-git-send-email-kalle.jokiniemi@nokia.com>

* Kalle Jokiniemi <kalle.jokiniemi@nokia.com> [110429 00:09]:
> The RX-51 uses the CSIb IO complex for camera operation. The
> board file is missing definition for the regulator supplying
> the CSIb complex, so this is added for better power
> management.
> 
> Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>

This looks safe to merge along with the other patch:

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  arch/arm/mach-omap2/board-rx51-peripherals.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index bbcb677..1324ba3 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -337,6 +337,13 @@ static struct omap2_hsmmc_info mmc[] __initdata = {
>  static struct regulator_consumer_supply rx51_vmmc1_supply =
>  	REGULATOR_SUPPLY("vmmc", "omap_hsmmc.0");
>  
> +static struct regulator_consumer_supply rx51_vaux2_supplies[] = {
> +	REGULATOR_SUPPLY("vdds_csib", "omap3isp"),
> +	{
> +		.supply = "vaux2",
> +	},
> +};
> +
>  static struct regulator_consumer_supply rx51_vaux3_supply =
>  	REGULATOR_SUPPLY("vmmc", "omap_hsmmc.1");
>  
> @@ -400,6 +407,8 @@ static struct regulator_init_data rx51_vaux2 = {
>  		.valid_ops_mask		= REGULATOR_CHANGE_MODE
>  					| REGULATOR_CHANGE_STATUS,
>  	},
> +	.num_consumer_supplies	= ARRAY_SIZE(rx51_vaux2_supplies),
> +	.consumer_supplies	= rx51_vaux2_supplies,
>  };
>  
>  /* VAUX3 - adds more power to VIO_18 rail */
> -- 
> 1.7.1
> 

  reply	other threads:[~2011-04-29  9:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-29  7:11 [PATCH 0/2] omap3isp/rx-51: Add vdds_csib regulator handling Kalle Jokiniemi
2011-04-29  7:11 ` [PATCH 1/2] OMAP3: ISP: Add regulator control for omap34xx Kalle Jokiniemi
2011-04-29  9:48   ` Laurent Pinchart
2011-04-29 13:03     ` kalle.jokiniemi
2011-04-29 13:03       ` kalle.jokiniemi
2011-05-02 11:09     ` kalle.jokiniemi
2011-05-02 11:09       ` kalle.jokiniemi
2011-04-29  7:12 ` [PATCH 2/2] OMAP3: RX-51: define vdds_csib regulator supply Kalle Jokiniemi
2011-04-29  9:13   ` Tony Lindgren [this message]
2011-05-02  9:15     ` kalle.jokiniemi
2011-05-02  9:15       ` kalle.jokiniemi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110429091337.GV3755@atomide.com \
    --to=tony@atomide.com \
    --cc=kalle.jokiniemi@nokia.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mchebab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.