From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFwG9-0005zw-2P for qemu-devel@nongnu.org; Fri, 29 Apr 2011 18:34:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QFwG8-00048X-1C for qemu-devel@nongnu.org; Fri, 29 Apr 2011 18:34:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFwG7-00048R-OA for qemu-devel@nongnu.org; Fri, 29 Apr 2011 18:33:59 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3TMXwOO029961 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 29 Apr 2011 18:33:58 -0400 Date: Sat, 30 Apr 2011 01:33:51 +0300 From: Alon Levy Message-ID: <20110429223351.GE13837@amber.local> References: <1304069912-21629-1-git-send-email-kraxel@redhat.com> <20110429112009.GB3771@playa> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110429112009.GB3771@playa> Subject: Re: [Qemu-devel] [PATCH 0/4] spice: fix locking List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org On Fri, Apr 29, 2011 at 02:20:09PM +0300, Alon Levy wrote: > On Fri, Apr 29, 2011 at 11:38:28AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > This patch series moves a bunch of work spice has to do from spice > > server thread context to iothread context, which in turn allows to > > drop the current locking mess as we don't touch qemu internals from > > spice server thread any more. > > > > A long-standing warning fix from Jes is included too. > > > > Tested with winxp, works well with changes between vga and qxl (tested > by setting the debug to 2 in spice-display.c). Just a single comment about > the debug=1 change in the second patch. > Forgot: ACK series > Alon > > > cheers, > > Gerd > > > > The following changes since commit 430a3c18064fd3c007048d757e8bd0fff45fcc99: > > > > configure: reenable opengl by default (2011-04-26 23:26:49 +0200) > > > > are available in the git repository at: > > git://anongit.freedesktop.org/spice/qemu spice.v34 > > > > Gerd Hoffmann (3): > > spice: don't create updates in spice server context. > > spice: don't call displaystate callbacks from spice server context. > > spice: drop obsolete iothread locking > > > > Jes Sorensen (1): > > Make spice dummy functions inline to fix calls not checking return values > > > > hw/qxl-render.c | 25 ++++++++++---------- > > hw/qxl.c | 27 ++++++++++----------- > > ui/qemu-spice.h | 12 ++++++++- > > ui/spice-display.c | 63 +++++++++++++++++++++++++++++++++------------------- > > ui/spice-display.h | 24 +++++++++++++++---- > > 5 files changed, 94 insertions(+), 57 deletions(-) > > >