From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
Cc: tony@atomide.com, sakari.ailus@nokia.com,
linux-omap@vger.kernel.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH 1/1] OMAP3: rx-51: Add full regulator definitions
Date: Sat, 30 Apr 2011 20:23:47 +0100 [thread overview]
Message-ID: <20110430192347.GB16378@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1304081264-4915-2-git-send-email-kalle.jokiniemi@nokia.com>
On Fri, Apr 29, 2011 at 03:47:44PM +0300, Kalle Jokiniemi wrote:
> + .always_on = true,
> + .valid_modes_mask = REGULATOR_MODE_NORMAL
> + | REGULATOR_MODE_STANDBY,
> + .valid_ops_mask = REGULATOR_CHANGE_MODE
> + | REGULATOR_CHANGE_STATUS,
_CHANGE_STATUS doesn't make much sense in conjunction with always_on.
Otherwise this looks OK to me.
next prev parent reply other threads:[~2011-04-30 19:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 12:47 [PATCH 0/1] RX-51: add full regulator definitions Kalle Jokiniemi
2011-04-29 12:47 ` [PATCH 1/1] OMAP3: rx-51: Add " Kalle Jokiniemi
2011-04-29 14:04 ` Jarkko Nikula
2011-05-02 4:42 ` kalle.jokiniemi
2011-05-02 5:19 ` kalle.jokiniemi
2011-05-02 6:57 ` Jarkko Nikula
2011-05-02 8:48 ` kalle.jokiniemi
2011-04-30 19:23 ` Mark Brown [this message]
2011-05-02 4:54 ` kalle.jokiniemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110430192347.GB16378@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=kalle.jokiniemi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sakari.ailus@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.