From: Samuel Ortiz <sameo@linux.intel.com>
To: Vincent Palatin <vpalatin@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Olof Johansson <olofj@chromium.org>
Subject: Re: [PATCH] mfd: fix tps6586x GPIO value setting
Date: Mon, 2 May 2011 11:21:52 +0200 [thread overview]
Message-ID: <20110502092151.GA740@sortiz-mobl> (raw)
In-Reply-To: <1302620158-6298-1-git-send-email-vpalatin@chromium.org>
Hi Vincent,
On Tue, Apr 12, 2011 at 10:55:58AM -0400, Vincent Palatin wrote:
> In the current code, every time we set a TPS6586x GPIO pin,
> the tps6586x_gpio_set function is resetting all other GPIO pins.
> We need to update the right GPIOxOUT bit of the GPIOSET2 register instead
> of overriding the full value.
>
> Tested by setting sequentially GPIO2 and GPIO3 and verifying the
> pins voltage.
Patch applied to my for-next branch, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2011-05-02 9:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 14:55 [PATCH] mfd: fix tps6586x GPIO value setting Vincent Palatin
2011-05-02 9:21 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502092151.GA740@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.