From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Mon, 02 May 2011 17:32:17 +0200 Subject: [U-Boot] [PATCH v9 10/10] adp-ag101: add board adp-ag101 support In-Reply-To: <1304342712-17120-10-git-send-email-macpaul@andestech.com> References: <1302180333-25372-1-git-send-email-macpaul@andestech.com> <1304342712-17120-10-git-send-email-macpaul@andestech.com> Message-ID: <20110502153217.64C94151F84@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Macpaul Lin, In message <1304342712-17120-10-git-send-email-macpaul@andestech.com> you wrote: > Add evaluation board "adp-ag101" aconfiguration file adp-ag101.h. > Add adp-ag101.c board config and related settings. > Add board adp-ag101 into boards.cfg ... > + if (expected_size != actual_size) > + printf("Warning: Only %lu of %lu MiB SDRAM is working\n", > + actual_size >> 20, expected_size >> 20); Please use braces around multi-line statements. > + if (banknum == 0) { /* non-CFI boot flash */ > + info->portwidth = FLASH_CFI_8BIT; > + info->chipwidth = FLASH_CFI_BY8; > + info->interface = FLASH_CFI_X8; > + return 1; > + } else > + return 0; Use braces in both branches. ... > +#define CONFIG_SYS_NS16550_COM1 CONFIG_FTUART010_02_BASE /* 0x99600000 */ Line too long. Please fix globally. ... > +#define CONFIG_SYS_FTAHBC020S_SLAVE_BSR_6 (FTAHBC020S_SLAVE_BSR_BASE(CONFIG_SYS_FTAHBC020S_SLAVE_BSR_BASE) | \ > + FTAHBC020S_SLAVE_BSR_SIZE(FTAHBC020S_SLAVE_BSR_SIZE_2G)) Ditto. > +/* memtest works on 63 MB in DRAM */ > +#define CONFIG_SYS_MEMTEST_START 0x00000000 > +#define CONFIG_SYS_MEMTEST_END 0x00200000 Comments and code are not in sync. > +/* relocation parameters */ > +#define CONFIG_SYS_RELO_ADDR 0x10000000 This should go, too. See previous message. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "There are some good people in it, but the orchestra as a whole is equivalent to a gang bent on destruction." - John Cage, composer