All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Marek Lindner <lindner_marek@yahoo.de>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: purge unnecessary include
Date: Mon, 2 May 2011 17:27:36 +0200	[thread overview]
Message-ID: <201105021727.37709.sven@narfation.org> (raw)
In-Reply-To: <201105021709.31468.lindner_marek@yahoo.de>

[-- Attachment #1: Type: Text/Plain, Size: 1026 bytes --]

On Monday 02 May 2011 17:09:31 Marek Lindner wrote:
> On Monday 02 May 2011 17:02:32 Sven Eckelmann wrote:
> > On Monday 02 May 2011 16:53:44 Marek Lindner wrote:
> > > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
> > 
> > [,,,,]
> > 
> > >  #include <linux/version.h>   /* LINUX_VERSION_CODE */
> > > 
> > > -#include "bat_sysfs.h"               /* struct bat_attribute */
> > 
> > This is necessary for kernels older than 2.6.24
> 
> Aarrrgh, I was afraid of something like that. We are running into an
> include dependency issue as soon as bat_sysfs.h contains something like
> "struct bat_priv" which is likely to come soon ...
> Any better idea how to fix this ?

Wait a second - why do you want to have a struct bat_priv in bat_sysfs.h? 
Isn't it possible to use 'struct bat_priv*" for a function declaration? 
'struct bat_priv;' can be used as forward declaration and used below in a 
function declaration.

struct bat_priv;
void test(struct bat_priv* a)
{
}

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2011-05-02 15:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-02 14:53 [B.A.T.M.A.N.] [PATCH] batman-adv: purge unnecessary include Marek Lindner
2011-05-02 15:02 ` Sven Eckelmann
2011-05-02 15:09   ` Marek Lindner
2011-05-02 15:22     ` Sven Eckelmann
2011-05-02 15:27     ` Sven Eckelmann [this message]
2011-05-02 15:47       ` Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201105021727.37709.sven@narfation.org \
    --to=sven@narfation.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=lindner_marek@yahoo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.