From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: mesa-dev@lists.freedesktop.org,
Benjamin Franzke <benjaminfranzke@googlemail.com>,
nouveau@lists.freedesktop.org
Subject: Re: [PATCH] gallium/xorg st/nv50/i915: add PIPE_BIND_CURSOR
Date: Mon, 2 May 2011 20:40:56 +0200 [thread overview]
Message-ID: <20110502184056.GD3461@joi.lan> (raw)
In-Reply-To: <BANLkTin7HGY12QcG7vc0aZ7mQ6SnZkrDJQ@mail.gmail.com>
On Mon, May 02, 2011 at 03:11:00PM +0200, Daniel Vetter wrote:
> On Mon, May 2, 2011 at 2:56 PM, Benjamin Franzke
> <benjaminfranzke@googlemail.com> wrote:
> > I think in i915g the CURSOR flag should be used in i9x5_scanout_layout
> > for the "special case for cursors" as well, instead of only checking
> > only pt->width0 == 64 && pt->height0 == 64.
>
> Oops, so much for actually re-checking the code. On the other hand, that
> part is broken, it needs a
> tex->tiling = I915_TILE_NONE;
> and perhaps some check that width == height == 64 indeed holds. Then
> move it out as the first if clause and it'd start to make sense ...
Could you fix it in separate patch?
I couldn't even test it...
Marcin
next prev parent reply other threads:[~2011-05-02 18:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-01 21:59 [PATCH] gallium/xorg st/nv50/i915: add PIPE_BIND_CURSOR Marcin Slusarz
2011-05-02 12:44 ` Daniel Vetter
2011-05-02 12:56 ` Benjamin Franzke
[not found] ` <BANLkTikbYs7y2gCELyyi1OKcuZYYVCfieA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-02 13:11 ` [Mesa-dev] " Daniel Vetter
2011-05-02 18:40 ` Marcin Slusarz [this message]
2011-05-03 10:06 ` Daniel Vetter
2011-05-08 22:33 ` Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502184056.GD3461@joi.lan \
--to=marcin.slusarz@gmail.com \
--cc=benjaminfranzke@googlemail.com \
--cc=daniel@ffwll.ch \
--cc=mesa-dev@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.