From: Ted Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: Fix fs corruption when make_indexed_dir() fails
Date: Tue, 3 May 2011 11:11:41 -0400 [thread overview]
Message-ID: <20110503151141.GC6462@thunk.org> (raw)
In-Reply-To: <1304112212-23417-1-git-send-email-jack@suse.cz>
On Fri, Apr 29, 2011 at 11:23:32PM +0200, Jan Kara wrote:
> When make_indexed_dir() fails (e.g. because of ENOSPC) after it has
> allocated block for index tree root, we did not properly mark all
> changed buffers dirty. This lead to only some of these buffers
> being written out and thus effectively corrupting the directory.
>
> Fix the issue by marking all changed data dirty even in the error
> failure case.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Thanks, added to the ext4 tree.
- Ted
prev parent reply other threads:[~2011-05-03 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 21:23 [PATCH 1/2] ext4: Fix fs corruption when make_indexed_dir() fails Jan Kara
2011-05-03 15:11 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503151141.GC6462@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.