From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [RFC][PATCH] Import Linux headers for KVM and
	vhost
Date: Tue, 3 May 2011 17:12:34 +0200
Message-ID: <20110503151234.GA13171@lst.de>
References: <4DC00BB1.7000008@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: qemu-devel <qemu-devel@nongnu.org>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>,
	Alexander Graf <agraf@suse.de>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.211]:45616 "EHLO newverein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752403Ab1ECPMe (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 3 May 2011 11:12:34 -0400
Content-Disposition: inline
In-Reply-To: <4DC00BB1.7000008@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, May 03, 2011 at 04:05:37PM +0200, Jan Kiszka wrote:
> This helps reducing our build-time checks for feature support in the
> available Linux kernel headers. And it helps users that do not have
> sufficiently recent headers installed on their build machine.
> 
> Header upstate is triggered via 'make update-linux-headers', optionally
> specifying a kernel directory as source via 'LINUX='.

Why not make it a shell scripts?  It's not like it's part of the build
system.  I also think the source tree argument should be mandatory instead
of grabbing random headers.


From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51837)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1QHHHA-0005EF-2u
	for qemu-devel@nongnu.org; Tue, 03 May 2011 11:12:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1QHHH9-0005gx-1W
	for qemu-devel@nongnu.org; Tue, 03 May 2011 11:12:36 -0400
Received: from verein.lst.de ([213.95.11.211]:40255 helo=newverein.lst.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1QHHH8-0005gt-Rm
	for qemu-devel@nongnu.org; Tue, 03 May 2011 11:12:35 -0400
Date: Tue, 3 May 2011 17:12:34 +0200
From: Christoph Hellwig <hch@lst.de>
Message-ID: <20110503151234.GA13171@lst.de>
References: <4DC00BB1.7000008@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4DC00BB1.7000008@siemens.com>
Subject: Re: [Qemu-devel] [RFC][PATCH] Import Linux headers for KVM and	vhost
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, kvm <kvm@vger.kernel.org>, Marcelo Tosatti <mtosatti@redhat.com>, Alexander Graf <agraf@suse.de>, qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>

On Tue, May 03, 2011 at 04:05:37PM +0200, Jan Kiszka wrote:
> This helps reducing our build-time checks for feature support in the
> available Linux kernel headers. And it helps users that do not have
> sufficiently recent headers installed on their build machine.
> 
> Header upstate is triggered via 'make update-linux-headers', optionally
> specifying a kernel directory as source via 'LINUX='.

Why not make it a shell scripts?  It's not like it's part of the build
system.  I also think the source tree argument should be mandatory instead
of grabbing random headers.