From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tommi Virtanen Subject: Re: [PATCH] libceph: fix ceph_msg_new error path Date: Tue, 3 May 2011 09:46:37 -0700 Message-ID: <20110503164637.GD20739@dreamer> References: <1304389796-11363-1-git-send-email-henry_c_chang@tcloudcomputing.com> <20110503161431.GA20739@dreamer> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.hq.newdream.net ([66.33.206.127]:46443 "EHLO mail.hq.newdream.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753850Ab1ECQqg (ORCPT ); Tue, 3 May 2011 12:46:36 -0400 Content-Disposition: inline In-Reply-To: <20110503161431.GA20739@dreamer> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Henry C Chang Cc: ceph-devel@vger.kernel.org, Henry C Chang On Tue, May 03, 2011 at 09:14:31AM -0700, Tommi Virtanen wrote: > On Tue, May 03, 2011 at 02:29:56AM +0000, Henry C Chang wrote: > > If memory allocation failed, calling ceph_msg_put() will cause GPF > > since some of ceph_msg variables are not initialized first. > > > > Fix Bug #970. > > Looks good and explains the symptoms perfectly. Committed to > ceph-client.git as 56f63aeb6360fb3ba9584bd5b094d55283a9e332. > Thanks! I backed that out in favor of Sage's commits to for-linus. Sorry about the confusion. -- :(){ :|:&};: