From mboxrd@z Thu Jan  1 00:00:00 1970
From: Greg KH <greg@kroah.com>
Subject: Re: [PATCH V4 2/5] USB: OTG: msm: vote for dayatona fabric clock
Date: Tue, 3 May 2011 10:15:39 -0700
Message-ID: <20110503171539.GA5969@kroah.com>
References: <1303977693-18389-1-git-send-email-pkondeti@codeaurora.org>
 <1304399633-16120-1-git-send-email-pkondeti@codeaurora.org>
 <1304399633-16120-3-git-send-email-pkondeti@codeaurora.org>
 <4DBFE39A.4010804@ru.mvista.com>
 <4DBFF531.1030208@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from kroah.org ([198.145.64.141]:52377 "EHLO coco.kroah.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753608Ab1ECRWy (ORCPT <rfc822;linux-arm-msm@vger.kernel.org>);
	Tue, 3 May 2011 13:22:54 -0400
Content-Disposition: inline
In-Reply-To: <4DBFF531.1030208@codeaurora.org>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Pavan Kondeti <pkondeti@codeaurora.org>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, davidb@codeaurora.org, Anji jonnala <anjir@codeaurora.org>

On Tue, May 03, 2011 at 05:59:37PM +0530, Pavan Kondeti wrote:
> Hi Sergei,
> 
> On 5/3/2011 4:44 PM, Sergei Shtylyov wrote:
> > Hello.
> > 
> > On 03-05-2011 9:13, Pavankumar Kondeti wrote:
> > 
> >> From: Anji jonnala <anjir@codeaurora.org>
> > 
> >> HSUSB core clock is derived from daytona fabric clock and for
> >> HSUSB operational require minimum core clock at 55MHz. Since, HSUSB
> >> cannot tolerate daytona fabric clock change in the middle of HSUSB
> >> operational, vote for maximum Daytona fabric clock
> >> while usb is operational
> > 
> >> Signed-off-by: Anji jonnala<anjir@codeaurora.org>
> >> Signed-off-by: Pavankumar Kondeti<pkondeti@codeaurora.org>
> > [...]
> > 
> >> diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c
> >> index 2965986..cfbb606 100644
> >> --- a/drivers/usb/otg/msm_otg.c
> >> +++ b/drivers/usb/otg/msm_otg.c
> > [...]
> >> @@ -954,7 +979,11 @@ free_regs:
> >>   put_core_clk:
> >>   	if (motg->core_clk)
> >>   		clk_put(motg->core_clk);
> >> -	clk_put(motg->pclk);
> > 
> >     Is it really correct to remove this line?
> > 
> No. It is not correct. I will fix it in next version.

Next version?

Ok, I'll drop all of these then from my queue.  Please resend when you
have something working properly.

thanks,

greg k-h