All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Yong Shen <yong.shen@linaro.org>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/2] regulator: Put mutex lock down to mc13783_powermisc_rmw function
Date: Tue, 3 May 2011 18:47:11 +0100	[thread overview]
Message-ID: <20110503174710.GH1762@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1304440830.16287.10.camel@phoenix>

On Wed, May 04, 2011 at 12:40:30AM +0800, Axel Lin wrote:
> mc13783_powermisc_rmw function is doing read/modify/write bitmask operations,
> thus add the lock to protect it.
> Then we can remove the lock/unlock from the caller.

This should be squashed in with the MFD patch I think otherwise we'll
get bisection points with either no lock or double locking (which upsets
lockdep IIRC).  The change itself looks good, though, and similarly for
patch 2

  parent reply	other threads:[~2011-05-03 17:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-03 16:40 [PATCH 1/2] regulator: Put mutex lock down to mc13783_powermisc_rmw function Axel Lin
2011-05-03 16:42 ` [PATCH 2/2] regulator: Put mutex lock down to mc13892_powermisc_rmw function Axel Lin
2011-05-03 17:47 ` Mark Brown [this message]
2011-05-04  4:33   ` [PATCH 1/2] regulator: Put mutex lock down to mc13783_powermisc_rmw function Axel Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110503174710.GH1762@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=axel.lin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=yong.shen@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.