From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: GIT Mailing-list <git@vger.kernel.org>,
trast@student.ethz.ch, Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC/PATCH] userdiff.c: Avoid old glibc regex bug causing t4034-*.sh test failures
Date: Tue, 3 May 2011 16:07:16 -0500 [thread overview]
Message-ID: <20110503210716.GL1019@elie> (raw)
In-Reply-To: <4DC04021.1040606@ramsay1.demon.co.uk>
Hi,
Ramsay Jones wrote:
> This is an RFC because:
> - A simple fix would be for me to put NO_REGEX=1 in my config.mak,
> since the compat/regex routines don't suffer this problem.
> - I suspect this bug is old enough that it will not affect many users.
> - I have not audited the other non-matching list expressions in
> userdiff.c
> - blame, grep and pickaxe all call regcomp() with the REG_NEWLINE
> flag, but get the regex from the user (eg from command line).
I think excluding \n along with ' ' and \t in similar places makes
sense, but that meanwhile we should add tests to the testsuite for
blame/grep/pickaxe to catch such implementations failing when
NO_REGEX=1 is not set.
Does that make sense? Thanks for tracking this down.
Jonathan
next prev parent reply other threads:[~2011-05-03 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 17:49 [RFC/PATCH] userdiff.c: Avoid old glibc regex bug causing t4034-*.sh test failures Ramsay Jones
2011-05-03 21:07 ` Jonathan Nieder [this message]
2011-05-07 17:54 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503210716.GL1019@elie \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.