From: Greg KH <gregkh@suse.de>
To: wanlong.gao@gmail.com
Cc: rdunlap@xenotime.net, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [resend PATCH] KernelDoc:Add the device driver-model structures to kerneldoc
Date: Tue, 3 May 2011 16:11:15 -0700 [thread overview]
Message-ID: <20110503231115.GA27014@suse.de> (raw)
In-Reply-To: <1304431649-5168-1-git-send-email-wanlong.gao@gmail.com>
On Tue, May 03, 2011 at 10:07:29PM +0800, wanlong.gao@gmail.com wrote:
> From: Wanlong Gao <wanlong.gao@gmail.com>
>
>
> Hi Greg:
> I did the work again with your comments, please see the patch again now.
>
> Thanks very much.
> Best regards
>
> Wanlong Gao
>
> Add the comments to the structure bus_type, device_driver, device,
> class for generating the driver-model kerneldoc.
>
> Signed-off-by: Wanlong Gao <wanlong.gao@gmail.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Why did you add my signed-off-by: to this patch? I did no such thing,
NEVER add someone's signed-off-by unless they really did so.
Despite that, the patch looks good to me as a great place to start out
with. Randy, I'm sure you have some grammer and punctuation that could
be fixed up?
thanks,
greg k-h
next prev parent reply other threads:[~2011-05-03 23:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 14:07 [resend PATCH] KernelDoc:Add the device driver-model structures to kerneldoc wanlong.gao
2011-05-03 23:11 ` Greg KH [this message]
2011-05-03 23:26 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503231115.GA27014@suse.de \
--to=gregkh@suse.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=wanlong.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.