Re: [PATCH 2/2 V2] kvm tools: Fix virt_queue__set_used_elem

[Ingo Molnar <mingo@elte.hu>]

* Sasha Levin <levinsasha928@gmail.com> wrote:

> On Tue, 2011-05-03 at 22:47 +0200, Ingo Molnar wrote:
> > * Sasha Levin <levinsasha928@gmail.com> wrote:
> > 
> > > Increase idx only after updating the used element.
> > > Not doing so may mark a buffer as used without having
> > > it's head and length updated.
> > > 
> > > Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> > > ---
> > >  tools/kvm/virtio.c |   19 ++++++++++++++++++-
> > >  1 files changed, 18 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/tools/kvm/virtio.c b/tools/kvm/virtio.c
> > > index 6249521..266a1b6 100644
> > > --- a/tools/kvm/virtio.c
> > > +++ b/tools/kvm/virtio.c
> > > @@ -1,15 +1,32 @@
> > >  #include <linux/virtio_ring.h>
> > >  #include <stdint.h>
> > >  #include <sys/uio.h>
> > > +#include <asm/system.h>
> > 
> > If this system.h is included from the current kernel (and not from the 
> > system's) then:
> > 
> > Acked-by: Ingo Molnar <mingo@elte.hu>
> > 
> 
> The system.h that'll get picked up is
> '../../arch/$(ARCH)/include/asm/system.h' within the current kernel tree
> and not the system one.

ok, that's great - so my Ack stands.

Thanks,

	Ingo