From: "Daniel P. Berrange" <berrange@redhat.com>
To: nick@bytemark.co.uk
Cc: nick@lupine.me.uk, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] IPv6 support for TCP migrations
Date: Wed, 4 May 2011 11:13:28 +0100 [thread overview]
Message-ID: <20110504101328.GC10300@redhat.com> (raw)
In-Reply-To: <1304498343-9141-1-git-send-email-nick@bytemark.co.uk>
On Wed, May 04, 2011 at 09:39:02AM +0100, nick@bytemark.co.uk wrote:
> Hi,
>
> Currently migration-tcp.c uses the IPv4-only socket functions, making
> migrations over IPv6 impossible. Following is a tentative patch that switches
> it to use inet_connect() and inet_listen().
>
> However, the patch loses the non-blocking connect() behaviour seen with the
> previous code. I'm not sure how much of an issue this is - if connect() blocks
> here, does it block execution of the VM?
>
> If so, I guess we need a non-blocking form of inet_connect(), or some way of
> replicating the behaviour - it would potentially be needed for my NBD
> reconnection patches too? I can see that a blocking connect() might not be an
> issue while the KVM process is starting up, but could cause problems if we
> try to reconnect while emulation is ongoing.
>
> Thoughts?
FWIW, Juan Quintela also posted a set of patches to add IPv6 support for
migration a few weeks back, but unfortunately they don't appear to have
been merged yet:
http://www.mail-archive.com/qemu-devel@nongnu.org/msg58954.html
IIUC, Juan's patches don't have the blocking connect() problem you
mention.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2011-05-04 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 8:39 [Qemu-devel] IPv6 support for TCP migrations nick
2011-05-04 8:39 ` [Qemu-devel] [PATCH] migration-tcp: Allow incoming and outgoing migrations over IPv6 nick
2011-05-04 10:13 ` Daniel P. Berrange [this message]
2011-05-04 10:50 ` [Qemu-devel] IPv6 support for TCP migrations Nicholas Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110504101328.GC10300@redhat.com \
--to=berrange@redhat.com \
--cc=nick@bytemark.co.uk \
--cc=nick@lupine.me.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.