From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2 07/12] OMAP: Serial: Allow UART parameters to be configured from board file Date: Wed, 4 May 2011 03:25:43 -0700 Message-ID: <20110504102543.GB2092@atomide.com> References: <1304080796-625-1-git-send-email-govindraj.raja@ti.com> <1304080796-625-8-git-send-email-govindraj.raja@ti.com> <20110504095546.GY2092@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:13400 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753262Ab1EDKZs (ORCPT ); Wed, 4 May 2011 06:25:48 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Govindraj Cc: "Govindraj.R" , linux-omap@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Deepak K , Benoit Cousson , Kevin Hilman , Paul Walmsley , Rajendra Nayak , Jon Hunter * Govindraj [110504 03:03]: > On Wed, May 4, 2011 at 3:25 PM, Tony Lindgren wrot= e: > > * Govindraj.R [110429 05:39]: > >> @@ -250,7 +251,7 @@ static void __init omap_2430sdp_init(void) > >> =C2=A0 =C2=A0 =C2=A0 omap2430_i2c_init(); > >> > >> =C2=A0 =C2=A0 =C2=A0 platform_add_devices(sdp2430_devices, ARRAY_S= IZE(sdp2430_devices)); > >> - =C2=A0 =C2=A0 omap_serial_init(); > >> + =C2=A0 =C2=A0 omap_serial_init(NULL); > >> =C2=A0 =C2=A0 =C2=A0 omap2_hsmmc_init(mmc); > >> =C2=A0 =C2=A0 =C2=A0 omap2_usbfs_init(&sdp2430_usb_config); > > ... > > > >> =C2=A0static inline void board_serial_init(void) > >> =C2=A0{ > >> - =C2=A0 =C2=A0 omap_serial_init(); > >> + =C2=A0 =C2=A0 omap_serial_init(NULL); > >> =C2=A0} > > > > This change seems like "crazy churn" and probably not needed > > if it's always null. Boards using platform_data can use > > omap_serial_init_port instead, right? >=20 > We can intiliaze only one uart port with omap_serial_init_port. >=20 > omap_serial_init initializes all uart port. >=20 > During any client device integration using dma mode > (for example Bluetooth) we can pass the dma config > params based on the board & client device. But you're changing all omap_serial_init() calls to omap_serial_init(NULL) so there are no users for that. It should be a separate patch if it's needed. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Wed, 4 May 2011 03:25:43 -0700 Subject: [PATCH v2 07/12] OMAP: Serial: Allow UART parameters to be configured from board file In-Reply-To: References: <1304080796-625-1-git-send-email-govindraj.raja@ti.com> <1304080796-625-8-git-send-email-govindraj.raja@ti.com> <20110504095546.GY2092@atomide.com> Message-ID: <20110504102543.GB2092@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Govindraj [110504 03:03]: > On Wed, May 4, 2011 at 3:25 PM, Tony Lindgren wrote: > > * Govindraj.R [110429 05:39]: > >> @@ -250,7 +251,7 @@ static void __init omap_2430sdp_init(void) > >> ? ? ? omap2430_i2c_init(); > >> > >> ? ? ? platform_add_devices(sdp2430_devices, ARRAY_SIZE(sdp2430_devices)); > >> - ? ? omap_serial_init(); > >> + ? ? omap_serial_init(NULL); > >> ? ? ? omap2_hsmmc_init(mmc); > >> ? ? ? omap2_usbfs_init(&sdp2430_usb_config); > > ... > > > >> ?static inline void board_serial_init(void) > >> ?{ > >> - ? ? omap_serial_init(); > >> + ? ? omap_serial_init(NULL); > >> ?} > > > > This change seems like "crazy churn" and probably not needed > > if it's always null. Boards using platform_data can use > > omap_serial_init_port instead, right? > > We can intiliaze only one uart port with omap_serial_init_port. > > omap_serial_init initializes all uart port. > > During any client device integration using dma mode > (for example Bluetooth) we can pass the dma config > params based on the board & client device. But you're changing all omap_serial_init() calls to omap_serial_init(NULL) so there are no users for that. It should be a separate patch if it's needed. Tony