All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Decreases code size of the nand_spl
Date: Wed, 4 May 2011 15:47:27 +0200	[thread overview]
Message-ID: <201105041547.27960.sr@denx.de> (raw)
In-Reply-To: <4DC15037.70109@dawning.com>

Hi Alex,

On Wednesday 04 May 2011 15:10:15 Alex Waterman wrote:
> From b59f1e5b0bc3684615756c12fd5c5f9fcaa4c812 Mon Sep 17 00:00:00 2001
> From: Alex Waterman <awaterman@dawning.com>
> Date: Tue, 3 May 2011 15:00:23 -0400
> Subject: [PATCH] Decreases code size of the nand_spl
> 
> The canyonland boards nand_spl size is just under the maximum 4KByte size.
> This patch decreases the size of the nand_spl to make a previous commit -
> commit 65a9db7be0868be91ba81b9b5bf821de82e6d9b0 - fit in the nand_spl.
> 
> Signed-off-by: Alex Waterman <awaterman@dawning.com>
> ---
> This patch uses a function pointer declared as a local variable; checkpatch
> didn't mind but this seems like it could be (stylistically) a very bad
> idea. Any thoughts?

Please see my patches sent a few hours ago:

"nand_spl: nand_boot.c: Init nand_chip.options to 0"
"nand_spl: nand_boot.c: Remove CONFIG_SYS_NAND_READ_DELAY"

The 2nd patch fixes the size problem as well. So no need for your patch any 
more.

But thanks anyway.

BTW: What platform/SoC are you using?

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

  reply	other threads:[~2011-05-04 13:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-04 13:10 [U-Boot] [PATCH] Decreases code size of the nand_spl Alex Waterman
2011-05-04 13:47 ` Stefan Roese [this message]
2011-05-04 14:03   ` Alex Waterman
2011-05-04 17:46   ` Scott Wood
2011-05-04 18:24     ` Alex Waterman
2011-05-04 18:43       ` Scott Wood
2011-05-04 19:24         ` [U-Boot] [PATCH v2] " Alex Waterman
2011-05-12 21:49           ` Wolfgang Denk
2011-05-12 21:57             ` Scott Wood
2011-05-12 22:00               ` Wolfgang Denk
2011-05-13  6:20             ` Stefan Roese
2011-05-13 16:16 ` [U-Boot] [PATCH] " Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201105041547.27960.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.