From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Remove unnecessary hardif_list_lock
Date: Wed, 4 May 2011 16:50:18 +0200 [thread overview]
Message-ID: <201105041650.19337.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1304416299-906-2-git-send-email-linus.luessing@web.de>
On Tuesday 03 May 2011 11:51:38 Linus Lüssing wrote:
> hardif_list_lock is unneccessary because we already ensure that no
> multiple admin operations can take place through rtnl_lock.
> hardif_list_lock only adds additional overhead and complexity.
>
> Critical functions now check whether they are called with rtnl_lock
> using ASSERT_RTNL.
>
> It indirectly fixes the problem that orig_hash_del_if() expects that
> only one interface is deleted from hardif_list at a time, but
> hardif_remove_interfaces() removes all at once and then calls
> orig_hash_del_if().
Applied in revision 7e95055.
Thanks,
Marek
next prev parent reply other threads:[~2011-05-04 14:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 19:19 [B.A.T.M.A.N.] [PATCHv4 1/2] batman-adv: Remove unnecessary hardif_list_lock Sven Eckelmann
2011-05-02 19:19 ` [B.A.T.M.A.N.] [PATCHv4 2/2] batman-adv: Avoid deadlock between rtnl_lock and s_active Sven Eckelmann
2011-05-03 9:51 ` [B.A.T.M.A.N.] (no subject) Linus Lüssing
2011-05-03 9:51 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Remove unnecessary hardif_list_lock Linus Lüssing
2011-05-03 11:10 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Avoid deadlock between rtnl_lock and s_active Linus Lüssing
2011-05-04 14:57 ` Marek Lindner
2011-05-04 14:50 ` Marek Lindner [this message]
2011-05-03 9:51 ` Linus Lüssing
2011-05-03 12:40 ` [B.A.T.M.A.N.] (no subject) Sven Eckelmann
-- strict thread matches above, loose matches on Subject: below --
2011-04-29 20:00 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Remove unnecessary hardif_list_lock Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105041650.19337.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.