Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig

[Greg KH <gregkh@suse.de>]

On Wed, May 04, 2011 at 07:54:09PM +0000, KY Srinivasan wrote:
> 
> 
> > -----Original Message-----
> > From: devel-bounces@linuxdriverproject.org [mailto:devel-
> > bounces@linuxdriverproject.org] On Behalf Of Greg KH
> > Sent: Wednesday, May 04, 2011 3:40 PM
> > To: Randy Dunlap
> > Cc: virtualization@lists.osdl.org; devel@linuxdriverproject.org; H Hartley
> > Sweeten; Haiyang Zhang; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv
> > Kconfig
> > 
> > On Wed, May 04, 2011 at 12:33:02PM -0700, Randy Dunlap wrote:
> > > On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote:
> > >
> > > > On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote:
> > > > > On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> > > > > >
> > > > > > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > > > > > Kconfig to reflect this.
> > > > > >
> > > > > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > > > > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> > > > > > ---
> > > > > >  drivers/staging/hv/Kconfig |    2 +-
> > > > > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > > > >
> > > > > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > > > > > index 76f0756..5e0c9f6 100644
> > > > > > --- a/drivers/staging/hv/Kconfig
> > > > > > +++ b/drivers/staging/hv/Kconfig
> > > > > > @@ -1,6 +1,6 @@
> > > > > >  config HYPERV
> > > > > >  	tristate "Microsoft Hyper-V client drivers"
> > > > > > -	depends on X86 && m
> > > > > > +	depends on X86 && ACPI && PCI && m
> > > > > >  	default n
> > > > > >  	help
> > > > > > 	  Select this option to run Linux as a Hyper-V client operating
> > > > >
> > > > > ACPI itself depends on PCI.
> > > >
> > > > Still?  I thought that got removed a while ago.
> > >
> > > Still.  Len has written in the past that technically there is no such
> > > dependency, but in reality there is, for now at least.  IIRC.
> > 
> > Ok, but then we should still say we depend on PCI to handle if/when ACPI
> > removes that dependancy in the future.  It doesn't hurt here at all.
> 
> Greg,
> I have sent you  both versions of this patch; one with explicit dependency on PCI and
> one with implicit dependency on PCI; you decide.

Thanks, I'll pick one :)