From: Michal Kiedrowicz <michal.kiedrowicz@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Martin Langhoff <martin.langhoff@gmail.com>
Subject: Re: [PATCH V2 4/5] git-grep: Learn PCRE
Date: Thu, 5 May 2011 10:38:39 +0200 [thread overview]
Message-ID: <20110505103839.2a051583@mkiedrowicz> (raw)
In-Reply-To: <4DC2567A.1060502@viscovery.net>
On 05.05.2011 09:49:14 +0200 Johannes Sixt <j.sixt@viscovery.net> wrote:
> Am 5/5/2011 9:41, schrieb Michal Kiedrowicz:
> > But I can abstract these calls to die_pcre_not_supported() to not
> > repeat die() message.
>
> Gah! Don't over-engineer. The compiler will un-duplicate the message
> texts for you if you carefully copy-and-paste them.
>
> -- Hannes
The whole point of using die_pcre_not_supported() is that it'll take
care of this "if you carefully copy-and-paste them" and remove
redundancy in _source code_, not binary. But still these die()'s are
minor nit (IMO).
next prev parent reply other threads:[~2011-05-05 8:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 22:00 [PATCH V2 0/5] Add PCRE support to git-grep Michał Kiedrowicz
2011-05-04 22:00 ` [PATCH V2 1/5] Documentation: Add --line-number to git-grep synopsis Michał Kiedrowicz
2011-05-04 22:00 ` [PATCH V2 2/5] contrib/completion: --line-number to git grep Michał Kiedrowicz
2011-05-04 22:00 ` [PATCH V2 3/5] grep: Put calls to fixmatch() and regmatch() into patmatch() Michał Kiedrowicz
2011-05-04 22:00 ` [PATCH V2 4/5] git-grep: Learn PCRE Michał Kiedrowicz
2011-05-05 1:09 ` Junio C Hamano
2011-05-05 5:47 ` Bert Wesarg
2011-05-05 16:55 ` Junio C Hamano
2011-05-05 6:19 ` Johannes Sixt
2011-05-05 7:41 ` Michal Kiedrowicz
2011-05-05 7:49 ` Johannes Sixt
2011-05-05 8:38 ` Michal Kiedrowicz [this message]
2011-05-05 6:28 ` Johannes Sixt
2011-05-05 7:43 ` Michal Kiedrowicz
2011-05-05 7:43 ` Alex Riesen
2011-05-04 22:00 ` [PATCH V2 5/5] configure: Check for libpcre Michał Kiedrowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505103839.2a051583@mkiedrowicz \
--to=michal.kiedrowicz@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=martin.langhoff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.