All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Ruiyi Zhang <Ruiyi.zhang@atheros.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Allow unsegmented SDU retries on sock_queue_rcv_skb failure.
Date: Thu, 5 May 2011 13:30:08 -0300	[thread overview]
Message-ID: <20110505163008.GA2139@joana> (raw)
In-Reply-To: <1303990781-15538-1-git-send-email-Ruiyi.zhang@atheros.com>

Hi Ruiyi,

* Ruiyi Zhang <Ruiyi.zhang@atheros.com> [2011-04-28 19:39:41 +0800]:

>  In L2CAP_SDU_UNSEGMENTED case, if sock_queue_rcv_skb returns error,
>  l2cap_ertm_reassembly_sdu should not return 0 so as to insert the
>  skb into BUSY_QUEUE for later retries.
> 
> 
> Signed-off-by: Ruiyi Zhang <Ruiyi.zhang@atheros.com>
> ---
>  net/bluetooth/l2cap_core.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index ca27f3a..3b2f140 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -2784,8 +2784,7 @@ static int l2cap_ertm_reassembly_sdu(struct sock *sk, struct sk_buff *skb, u16 c
>  			goto drop;
>  
>  		err = sock_queue_rcv_skb(sk, skb);
> -		if (!err)
> -			return err;
> +		return err;
>  
>  		break;

I prefer simply
		return sock_queue_rcv_skb();

and remove the break inclusive.

-- 
Gustavo F. Padovan
http://profusion.mobi

  reply	other threads:[~2011-05-05 16:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-28 11:39 [PATCH] Bluetooth: Allow unsegmented SDU retries on sock_queue_rcv_skb failure Ruiyi Zhang
2011-05-05 16:30 ` Gustavo F. Padovan [this message]
2011-05-06  4:44 ` [PATCH v2] " Ruiyi Zhang
2011-05-11 17:55   ` Gustavo F. Padovan
2011-05-13  5:07     ` [PATCH v3] " Ruiyi Zhang
2011-05-13 18:23       ` Gustavo F. Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110505163008.GA2139@joana \
    --to=padovan@profusion.mobi \
    --cc=Ruiyi.zhang@atheros.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.