All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>,
	Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tools: Makefile: Use gcc to determine ARCH
Date: Sat, 7 May 2011 11:40:06 +0200	[thread overview]
Message-ID: <20110507094006.GH27657@elte.hu> (raw)
In-Reply-To: <1304743274.3132.17.camel@localhost>


* Lin Ming <ming.m.lin@intel.com> wrote:

> The original Makefile uses "uname -m" to determine ARCH.
> This causes problem on x86 when compile perf tool on 32 bit userspace
> with a 64 bit kernel.
> 
> bench/../../../arch/x86/lib/memcpy_64.S: Assembler messages:
> bench/../../../arch/x86/lib/memcpy_64.S:28: Error: bad register name `%rdi'
> 
> This is because "uname -m" returns x86_64 and memcpy_64.S is included in 32 bit build.
> 
> Signed-off-by: Lin Ming <ming.m.lin@intel.com>

this changelog is missing an important line:

 Reported-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>

I've added it.

Thanks,

	Ingo

  reply	other threads:[~2011-05-07  9:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-07  4:41 [PATCH] perf tools: Makefile: Use gcc to determine ARCH Lin Ming
2011-05-07  9:40 ` Ingo Molnar [this message]
2011-05-07  9:46 ` [tip:perf/urgent] " tip-bot for Lin Ming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110507094006.GH27657@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=riccardo.magliocchetti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.