Re: [PATCH] kvm tools: Enable earlyprintk=serial by default

[Rodrigo Campos <rodrigo@sdfg.com.ar>]

On Sun, May 08, 2011 at 09:39:34AM +0200, Ingo Molnar wrote:
> 
> diff --git a/tools/kvm/kvm-run.c b/tools/kvm/kvm-run.c
> index 764a242..eb50b6a 100644
> --- a/tools/kvm/kvm-run.c
> +++ b/tools/kvm/kvm-run.c
> @@ -409,7 +409,7 @@ int kvm_cmd_run(int argc, const char **argv, const char *prefix)
>  	kvm->nrcpus = nrcpus;
>  
>  	memset(real_cmdline, 0, sizeof(real_cmdline));
> -	strcpy(real_cmdline, "notsc noapic noacpi pci=conf1 console=ttyS0 ");
> +	strcpy(real_cmdline, "notsc noapic noacpi pci=conf1 console=ttyS0 earlyprintk=serial");

I think the space at the end of the string that you delete, squashes the early
printk option with the next one (root= in your case), like in the output you show:

>  [    0.000000] Command line: notsc noapic noacpi pci=conf1 console=ttyS0 earlyprintk=serialroot=/dev/vda1 rw 
I mean here                                                                                   ^





Thanks,
Rodrigo