From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] external-toolchain: fix support
Date: Mon, 9 May 2011 08:58:54 +0200 [thread overview]
Message-ID: <20110509085854.0862d1fb@surf> (raw)
In-Reply-To: <87vcxlj74a.fsf@macbook.be.48ers.dk>
Hello,
On Sun, 08 May 2011 21:59:49 +0200
Peter Korsgaard <jacmet@uclibc.org> wrote:
> The commit would have been a bit smaller if we simply replaced
> TARGET_CC with TOOLCHAIN_EXTERNAL_CC (and same for C++) as we only
> use these macros from ex-tool.mk anyway, but ok.
Yes, but while TARGET_CC can be considered as a global variable, I
don't consider TOOLCHAIN_EXTERNAL_CC to be a global one, but a local
variable to ext-tool.mk (I know 'make' doesn't provide any sort of
variable scoping mechanism, but still). For that reason, I thought that
passing the compiler path was a clearer solution.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2011-05-09 6:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 16:52 [Buildroot] [pull request] Pull request for branch for-2011.05/fix-ext-toolchain-support Thomas Petazzoni
2011-05-08 16:52 ` [Buildroot] [PATCH 1/1] external-toolchain: fix support Thomas Petazzoni
2011-05-08 19:59 ` Peter Korsgaard
2011-05-09 6:58 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509085854.0862d1fb@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.