From: Christoph Hellwig <hch@infradead.org>
To: Lukas Czerner <lczerner@redhat.com>
Cc: Jens Axboe <jaxboe@fusionio.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Monakhov <dmonakhov@openvz.org>,
Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PATCH 1/3] blkdev: Submit discard bio in batches in blkdev_issue_discard()
Date: Mon, 9 May 2011 10:30:27 -0400 [thread overview]
Message-ID: <20110509143027.GA29635@infradead.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1105051717050.3760@dhcp-27-109.brq.redhat.com>
On Thu, May 05, 2011 at 05:20:40PM +0200, Lukas Czerner wrote:
> > Good results. It'd be more efficient to add the vectored discard support
> > and use it for this too though, and it would get rid of the need to wait
> > on the batches since there'd be just one discard bio for the ranges.
> >
>
> Since we do not have vectored discard yet, can this change go in as it
> is ? Also, Christoph thinks that it would not help anyway since the we do
> batch the discard requests only when it exceeds the max range.
I think this patch is orthogonal to vectored discard. The batching
is important for large ranges which generally come from BLKDISCARD or
FITRIM, while vectored discard is mostly interesting for lots of small
discards at transaction commit time.
next prev parent reply other threads:[~2011-05-09 14:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 14:17 [PATCH 1/3] blkdev: Submit discard bio in batches in blkdev_issue_discard() Lukas Czerner
2011-05-02 14:17 ` [PATCH 2/3] blkdev: Simple cleanup in blkdev_issue_zeroout() Lukas Czerner
2011-05-02 14:17 ` [PATCH 3/3] blkdev: honor discard_granularity in blkdev_issue_discard() Lukas Czerner
2011-05-02 14:38 ` Martin K. Petersen
2011-05-02 16:10 ` Jeff Moyer
2011-05-02 17:07 ` Martin K. Petersen
2011-05-02 23:21 ` Dave Chinner
2011-05-02 16:23 ` [PATCH 1/3] blkdev: Submit discard bio in batches " Jens Axboe
2011-05-03 9:30 ` Lukas Czerner
2011-05-03 9:30 ` Lukas Czerner
2011-05-03 9:57 ` Christoph Hellwig
2011-05-07 1:23 ` Jens Axboe
2011-05-05 15:20 ` Lukas Czerner
2011-05-05 15:20 ` Lukas Czerner
2011-05-07 1:24 ` Jens Axboe
2011-05-09 14:30 ` Christoph Hellwig [this message]
2011-05-05 15:12 ` [PATCH] blkdev: Do not return -EOPNOTSUPP if discard is supported Lukas Czerner
2011-05-07 1:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509143027.GA29635@infradead.org \
--to=hch@infradead.org \
--cc=dmonakhov@openvz.org \
--cc=jaxboe@fusionio.com \
--cc=jmoyer@redhat.com \
--cc=lczerner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.