From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Andy Ross <andy.ross@windriver.com>
Cc: Anisse Astier <anisse@astier.eu>,
linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org,
Dmitry Torokhov <dtor@mail.ru>,
Corentin Chary <corentin.chary@gmail.com>
Subject: Re: [RFC] Reporting "orientation changed" event
Date: Mon, 9 May 2011 16:47:29 +0100 [thread overview]
Message-ID: <20110509154729.GA5043@srcf.ucam.org> (raw)
In-Reply-To: <4DC80A53.7050609@windriver.com>
On Mon, May 09, 2011 at 08:37:55AM -0700, Andy Ross wrote:
> How would that work? If it's an extra sysfs node, it would require an
> extra file descriptor in the reader. And if it's an event inside the
> input stream, that would require the reader implement handling to throttle
> the polling rate. The point here was to avoid having to poll the
> (noisy) accelerometer stream just for gross orientation changes.
Yes, so the accelerometer driver should (in-kernel) know that a coarse
orientation event has occured and then send an appropriate uevent to
userspace indiciating that it has new data.
> http://build.meego.com/package/files?package=sensorfw-pegatron&project=Trunk
Yeah, that's absolutely dreadful. Don't do that.
> Does it really need to be "fixed"? If this were a whole class of
> hardware, then I guess I'd agree. But right now it's one quirky
> device.
I'm going to NAK anything that reports "Coarse orientation change" to
userspace without providing any context.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-05-09 15:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 16:18 [RFC] Reporting "orientation changed" event Anisse Astier
2011-04-07 16:37 ` Bastien Nocera
2011-04-07 16:44 ` Anisse Astier
2011-04-07 17:01 ` Jonathan Cameron
2011-04-07 17:19 ` Anisse Astier
2011-05-09 14:38 ` Matthew Garrett
2011-05-09 15:37 ` Andy Ross
2011-05-09 15:47 ` Matthew Garrett [this message]
2011-05-09 15:59 ` Andy Ross
2011-05-09 16:30 ` Anisse Astier
2011-05-09 16:40 ` Matthew Garrett
2011-05-09 17:58 ` Anisse Astier
2011-05-09 18:06 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509154729.GA5043@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=andy.ross@windriver.com \
--cc=anisse@astier.eu \
--cc=corentin.chary@gmail.com \
--cc=dtor@mail.ru \
--cc=linux-input@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.