From: Greg KH <greg@kroah.com>
To: Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
LPPC <linuxppc-dev@lists.ozlabs.org>,
Prasad <prasad@linux.vnet.ibm.com>
Cc: stable@kernel.org
Subject: Re: [stable] Patch Upstream: hw_breakpoints, powerpc: Fix CONFIG_HAVE_HW_BREAKPOINT off-case in ptrace_set_debugreg()
Date: Mon, 9 May 2011 16:33:02 -0700 [thread overview]
Message-ID: <20110509233302.GA3721@kroah.com> (raw)
In-Reply-To: <201105072120.p47LK2IJ016755@hera.kernel.org>
On Sat, May 07, 2011 at 09:20:02PM +0000, James Bottomley wrote:
> commit: 925f83c085e1bb08435556c5b4844a60de002e31
> From: Frederic Weisbecker <fweisbec@gmail.com>
> Date: Fri, 6 May 2011 01:53:18 +0200
> Subject: [PATCH] hw_breakpoints, powerpc: Fix CONFIG_HAVE_HW_BREAKPOINT
> off-case in ptrace_set_debugreg()
>
> We make use of ptrace_get_breakpoints() / ptrace_put_breakpoints() to
> protect ptrace_set_debugreg() even if CONFIG_HAVE_HW_BREAKPOINT if off.
> However in this case, these APIs are not implemented.
>
> To fix this, push the protection down inside the relevant ifdef.
> Best would be to export the code inside
> CONFIG_HAVE_HW_BREAKPOINT into a standalone function to cleanup
> the ifdefury there and call the breakpoint ref API inside. But
> as it is more invasive, this should be rather made in an -rc1.
>
> Fixes this build error:
>
> arch/powerpc/kernel/ptrace.c:1594: error: implicit declaration of function 'ptrace_get_breakpoints' make[2]: ***
>
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: LPPC <linuxppc-dev@lists.ozlabs.org>
> Cc: Prasad <prasad@linux.vnet.ibm.com>
> Cc: v2.6.33.. <stable@kernel.org>
This patch applied after I tweaked it to the .38-stable tree, but it
doesn't apply at all to 2.6.33-stable. If someone wants to see it
there, please send a backported patch to stable@kernel.org.
parent reply other threads:[~2011-05-10 0:17 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <201105072120.p47LK2IJ016755@hera.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509233302.GA3721@kroah.com \
--to=greg@kroah.com \
--cc=fweisbec@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@elte.hu \
--cc=prasad@linux.vnet.ibm.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.