From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
git@vger.kernel.org, "SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH v4 (for maint)] git-completion: fix zsh support
Date: Mon, 9 May 2011 18:35:06 -0500 [thread overview]
Message-ID: <20110509233506.GC23781@elie> (raw)
In-Reply-To: <7v1v07o3rs.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> One big thing going for this patch is that this is the blessed solution
> zsh folks themselves like to use, no? The repeated mention "zsh bashinit
> bug" in the code seems to suggest that it is the case.
>
> I do not mind reverting sg/completion-updates from 'next' (please remind
> me that I need to resurrect your "private shopt shim" separately if we go
> this route) and applying a cleaned-up version of this one.
Thanks, will spend some time later today to do so.
> Thanks.
Sorry for all the noise. I wish I knew a way to work on patches like
this one without causing so much animosity.
next prev parent reply other threads:[~2011-05-09 23:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 20:45 [PATCH v3 (for maint)] git-completion: fix zsh support Felipe Contreras
2011-05-09 21:13 ` Jonathan Nieder
2011-05-09 22:08 ` Felipe Contreras
2011-05-09 22:14 ` [PATCH v4 " Felipe Contreras
2011-05-09 22:53 ` Jonathan Nieder
2011-05-09 23:13 ` Felipe Contreras
2011-05-09 23:28 ` Jonathan Nieder
2011-05-09 23:58 ` Felipe Contreras
2011-05-09 23:25 ` Junio C Hamano
2011-05-09 23:35 ` Jonathan Nieder [this message]
2011-05-10 2:55 ` [PATCH v5 0/2] " Jonathan Nieder
2011-05-10 2:59 ` [PATCH 1/2] completion: suppress zsh's special 'words' variable Jonathan Nieder
2011-05-10 3:17 ` Jonathan Nieder
2011-05-10 11:43 ` Felipe Contreras
2011-05-10 11:29 ` Felipe Contreras
2011-05-10 3:00 ` [PATCH 2/2] completion: move private shopt shim for zsh to __git_ namespace Jonathan Nieder
2011-05-10 10:48 ` [PATCH v5 0/2] git-completion: fix zsh support Felipe Contreras
2011-05-10 2:04 ` [PATCH v3 (for maint)] " Jonathan Nieder
2011-05-10 10:44 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509233506.GC23781@elie \
--to=jrnieder@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.