From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754096Ab1EJJhu (ORCPT ); Tue, 10 May 2011 05:37:50 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:51013 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753088Ab1EJJhs (ORCPT ); Tue, 10 May 2011 05:37:48 -0400 Date: Tue, 10 May 2011 11:37:41 +0200 From: Ingo Molnar To: "Paul E. McKenney" Cc: Yinghai Lu , linux-kernel@vger.kernel.org Subject: Re: [GIT PULL rcu/next] rcu commits for 2.6.40 Message-ID: <20110510093741.GA2400@elte.hu> References: <20110508151848.GA21906@linux.vnet.ibm.com> <20110509073636.GA18247@elte.hu> <20110510085623.GG2258@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20110510085623.GG2258@linux.vnet.ibm.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Paul E. McKenney wrote: > On Mon, May 09, 2011 at 02:09:21PM -0700, Yinghai Lu wrote: > > On Mon, May 9, 2011 at 12:36 AM, Ingo Molnar wrote: > > > > > > * Paul E. McKenney wrote: > > > > > >> Hello, Ingo, > > >> > > >> This pull request covers RCU chnages for 2.6.40.  The major new features > > >> are RCU priority boosting and the addition of kfree_rcu(), the latter > > >> courtesy of Lai Jiangshan.  These two features cover well over half > > >> of the commits.  There are a number of smaller features and bug fixes. > > >> All have been sent to LKML in the following batches: > > >> > > >> 0.    https://lkml.org/lkml/2011/2/22/660: RCU priority boosting preview > > >> 1.    https://lkml.org/lkml/2011/5/1/19: RCU priority boosting, kfree_rcu() > > >> 2.    https://lkml.org/lkml/2011/5/2/40: More uses of kfree_rcu() > > >> 3.    https://lkml.org/lkml/2011/5/8/60: miscellaneous > > >> > > >> The kfree_rcu() uses in the pull request have Acked-by:s from the > > >> maintainers.  I have some additional kfree_rcu() requests that lack > > >> Acked-by:s, and I will deal with these later. > > >> > > >> These channges are available in the -rcu git repository at: > > >> > > >>   git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-2.6-rcu.git rcu/next > > > > > > Pulled, thanks a lot Paul! > > > > > > > it seems with this one in tip, my 8 sockets test setup will report cpu stall. > > > > after hard code to enable rcu_cpu_stall_suppress > > > > Index: linux-2.6/kernel/rcutree.c > > =================================================================== > > --- linux-2.6.orig/kernel/rcutree.c > > +++ linux-2.6/kernel/rcutree.c > > @@ -174,7 +174,7 @@ module_param(blimit, int, 0); > > module_param(qhimark, int, 0); > > module_param(qlowmark, int, 0); > > > > -int rcu_cpu_stall_suppress __read_mostly; > > +int rcu_cpu_stall_suppress __read_mostly = 1; > > module_param(rcu_cpu_stall_suppress, int, 0644); > > > > static void force_quiescent_state(struct rcu_state *rsp, int relaxed); > > > > will get system hang after pnp ACPI init. > > Could you please send the stack traces from the RCU CPU stall? Also, > you do have ce31332d3c77532d6ea97ddcb475a2b02dd358b4 applied, correct? if the failure is reproducible then bisection would be helpful as well. Thanks, Ingo