From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932675Ab1EKXEq (ORCPT ); Wed, 11 May 2011 19:04:46 -0400 Received: from cantor.suse.de ([195.135.220.2]:36358 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753402Ab1EKXEp (ORCPT ); Wed, 11 May 2011 19:04:45 -0400 Date: Wed, 11 May 2011 15:55:40 -0700 From: Greg KH To: MyungJoo Ham Cc: linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Mark Brown , Jiejing Zhang , Pavel Machek , Colin Cross , Nishanth Menon , Thomas Gleixner , Len Brown , Kyungmin Park , myungjoo.ham@gmail.com Subject: Re: [PATCH v2 3/3] PM / DEVFREQ: add sysfs interface (including user tickling) Message-ID: <20110511225540.GA3492@suse.de> References: <1305100723-29161-1-git-send-email-myungjoo.ham@samsung.com> <1305100723-29161-3-git-send-email-myungjoo.ham@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1305100723-29161-3-git-send-email-myungjoo.ham@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2011 at 04:58:43PM +0900, MyungJoo Ham wrote: > 1. System-wide sysfs interface > - tickle_all R: number of tickle_all execution > W: tickle all devfreq devices > - min_interval R: devfreq monitoring base interval in ms > - monitoring R: shows whether devfreq monitoring is active or > not. > > 2. Device specific sysfs interface > - tickle R: number of tickle execution for the device > W: tickle the device Any sysfs file change/addition/removal needs to have a Documentation/ABI/ entry as well. Please add that to this patch instead of burying it in the changelog entry, where no one will be able to find it in the future. thanks, greg k-h