From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 12 May 2011 14:54:47 +0200 Subject: [PATCH v4 1/1] can: add pruss CAN driver. In-Reply-To: <4DCB88A4.2010901@grandegger.com> References: <1303474267-6344-1-git-send-email-subhasish@mistralsolutions.com> <201105112344.44171.arnd@arndb.de> <4DCB88A4.2010901@grandegger.com> Message-ID: <201105121454.47781.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 12 May 2011, Wolfgang Grandegger wrote: > Well, that seems sophisticated resulting in a complex implementation > (may code line) also because hardware filters are very hardware > dependent. Usually just one global filter can be defined. I think that's > overkill. A simple interface using: > > ip link set can0 type can filter : [: ...] > > would just be fine. Ok, fair enough. Still I would suggest you first come up with a reasonable user interface (the one you posted may be just right, I don't know), and then let someone do the implementation in the pruss firmware that is the best match for the user interface, rather than the other way around. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755853Ab1ELM5D (ORCPT ); Thu, 12 May 2011 08:57:03 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:54480 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752607Ab1ELM5A (ORCPT ); Thu, 12 May 2011 08:57:00 -0400 From: Arnd Bergmann To: Wolfgang Grandegger Subject: Re: [PATCH v4 1/1] can: add pruss CAN driver. Date: Thu, 12 May 2011 14:54:47 +0200 User-Agent: KMail/1.12.2 (Linux/2.6.37; KDE/4.3.2; x86_64; ; ) Cc: Subhasish Ghosh , sachi@mistralsolutions.com, davinci-linux-open-source@linux.davincidsp.com, Alan Cox , Netdev@vger.kernel.org, nsekhar@ti.com, open list , CAN NETWORK DRIVERS , "Marc Kleine-Budde" , m-watkins@ti.com, linux-arm-kernel@lists.infradead.org References: <1303474267-6344-1-git-send-email-subhasish@mistralsolutions.com> <201105112344.44171.arnd@arndb.de> <4DCB88A4.2010901@grandegger.com> In-Reply-To: <4DCB88A4.2010901@grandegger.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105121454.47781.arnd@arndb.de> X-Provags-ID: V02:K0:4WClrivG7ngWfI018/nbBl5tXTB3CS8+JqSNEyv76HC GhCjULW3gfHnsUj8P/aR8H/SWGF9XwXq4Pm7JdgTG9WWCLCUle 77yzoFtXDU0c2SO47NOM4f60GwG6Jp5tD80fi87TZ3WgVDkLqH LnSF3qCSILrFuJXFbF2l1dUOpjIyzGNjHqeODkxPuIeQcBSNGS rgiaWSIynRov7sJaMmXrQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 12 May 2011, Wolfgang Grandegger wrote: > Well, that seems sophisticated resulting in a complex implementation > (may code line) also because hardware filters are very hardware > dependent. Usually just one global filter can be defined. I think that's > overkill. A simple interface using: > > ip link set can0 type can filter : [: ...] > > would just be fine. Ok, fair enough. Still I would suggest you first come up with a reasonable user interface (the one you posted may be just right, I don't know), and then let someone do the implementation in the pruss firmware that is the best match for the user interface, rather than the other way around. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v4 1/1] can: add pruss CAN driver. Date: Thu, 12 May 2011 14:54:47 +0200 Message-ID: <201105121454.47781.arnd@arndb.de> References: <1303474267-6344-1-git-send-email-subhasish@mistralsolutions.com> <201105112344.44171.arnd@arndb.de> <4DCB88A4.2010901@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: sachi-EvXpCiN+lbve9wHmmfpqLFaTQe2KTcn/@public.gmane.org, davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, Subhasish Ghosh , nsekhar-l0cyMroinI0@public.gmane.org, open list , CAN NETWORK DRIVERS , Marc Kleine-Budde , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, m-watkins-l0cyMroinI0@public.gmane.org, Alan Cox To: Wolfgang Grandegger Return-path: In-Reply-To: <4DCB88A4.2010901-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On Thursday 12 May 2011, Wolfgang Grandegger wrote: > Well, that seems sophisticated resulting in a complex implementation > (may code line) also because hardware filters are very hardware > dependent. Usually just one global filter can be defined. I think that's > overkill. A simple interface using: > > ip link set can0 type can filter : [: ...] > > would just be fine. Ok, fair enough. Still I would suggest you first come up with a reasonable user interface (the one you posted may be just right, I don't know), and then let someone do the implementation in the pruss firmware that is the best match for the user interface, rather than the other way around. Arnd