From: Ben Pfaff <blp@nicira.com>
To: Christopher Li <sparse@chrisli.org>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH] evaluate: Allow sizeof(_Bool) to succeed.
Date: Thu, 12 May 2011 13:48:06 -0700 [thread overview]
Message-ID: <20110512204806.GC3371@nicira.com> (raw)
In-Reply-To: <BANLkTinHEgDw24S=mcE6B7OeirrHk+ZSog@mail.gmail.com>
On Wed, May 11, 2011 at 05:09:42PM -0700, Christopher Li wrote:
> On Mon, May 9, 2011 at 1:49 PM, Ben Pfaff <blp@nicira.com> wrote:
> > I could change my IDL code generator to do something different for
> > this case, but I don't see anything actually wrong with it. ?This
> > userspace code is not performance-critical or sensitive to memory
> > usage, so it's not necessary on the face of it to optimize it.
>
> Removing the warning will lose the chance to see it on other potential
> problematic usage. If you insist on no warning. You can submit a patch
> to add a switch to disable it. We have a lot of those for fine grain warning
> control. I just don't see this warning can hurt on the kernel checking side.
For now, I've decided to just rewrite code on the Open vSwitch side to
avoid sizeof(_Bool) entirely. If it becomes a problem again, I'll
submit a -Wno-sizeof-bool patch.
Thanks for considering my reasons.
Ben
prev parent reply other threads:[~2011-05-12 20:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 23:39 [PATCH] evaluate: Allow sizeof(_Bool) to succeed Ben Pfaff
2011-05-07 20:37 ` Christopher Li
2011-05-09 20:02 ` Ben Pfaff
2011-05-09 20:31 ` Christopher Li
2011-05-09 20:49 ` Ben Pfaff
2011-05-12 0:09 ` Christopher Li
2011-05-12 20:48 ` Ben Pfaff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110512204806.GC3371@nicira.com \
--to=blp@nicira.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.